Implement `HOST_UDF` aggregation for reduction and segmented reduction #17645

ttnghia · 2024-12-20T19:25:48Z

Following #17592, this enables HOST_UDF aggregation in reduction and segmented reduction, allowing to execute a host-side user-defined function (UDF) through libcudf aggregation framework.

Closes #16633.

Signed-off-by: Nghia Truong <[email protected]>

cpp/include/cudf/aggregation/host_udf.hpp

Signed-off-by: Nghia Truong <[email protected]>

ttnghia · 2024-12-29T17:50:28Z

The logic for host_udf_base interface is changed in this PR. Instead of one universal interface for aggregation contexts (groupby/reduction/segmented reduction) as designed in the previous work, now there are three separate interfaces for them. Implementation for each context needs to derive from the corresponding interface.

Because the interfaces are no longer designed to be universal for all contexts, they are much simpler, avoiding potential bugs due to universal usage of one interface for different contexts.

Signed-off-by: Nghia Truong <[email protected]>

ttnghia · 2025-01-07T18:40:55Z

java/src/main/java/ai/rapids/cudf/Aggregation.java

@@ -1,6 +1,6 @@
 /*
 *
- *  Copyright (c) 2020-2023, NVIDIA CORPORATION.
+ *  Copyright (c) 2020-2025, NVIDIA CORPORATION.


Change the copyright header for the files that were forgotten in the previous PR. Github CI seems does not check Java files.

cpp/include/cudf/aggregation/host_udf.hpp

Co-authored-by: nvdbaranec <[email protected]>

Signed-off-by: Nghia Truong <[email protected]>

sperlingxx · 2025-01-10T09:52:48Z

java/src/main/java/ai/rapids/cudf/ReductionAggregation.java

@@ -256,7 +256,7 @@ public static ReductionAggregation collectSet() {
   * @param nanEquality  Flag to specify whether NaN values in floating point column should be considered equal.
   */
  public static ReductionAggregation collectSet(NullPolicy nullPolicy,
-      NullEquality nullEquality, NaNEquality nanEquality) {
+                                                NullEquality nullEquality, NaNEquality nanEquality) {


Are these style adjustments necessary?

I think so. This is what the IDE automatically reformat. I checked other files and this seems consistent. For example:

cudf/java/src/main/java/ai/rapids/cudf/ColumnVector.java

Lines 151 to 153 in a6b9699

public ColumnVector(DType type, long rows, Optional<Long> nullCount,

DeviceMemoryBuffer dataBuffer, DeviceMemoryBuffer validityBuffer,

DeviceMemoryBuffer offsetBuffer, List<DeviceMemoryBuffer> toClose, long[] childHandles) {

revans2

From a java standpoint the code matches what was there before.

KyleFromNVIDIA

Approved trivial CMake changes

PointKernel

I'm really happy with the final outcome of this PR. The finalized APIs are much more accessible and user-friendly. I appreciate your prompt responses to the review comments and the time you took for offline discussions to address all my concerns and answer my questions.

Looks good to me!

cpp/include/cudf/aggregation/host_udf.hpp

Co-authored-by: Yunsong Wang <[email protected]>

Signed-off-by: Nghia Truong <[email protected]>

ttnghia added 3 commits December 20, 2024 10:48

Implement HOST_UDF aggregation for reduction and segmented reduction

2da9137

Signed-off-by: Nghia Truong <[email protected]>

Merge branch 'branch-25.02' into host_udf_reduction

fca442a

Fix example

4b5aa95

Signed-off-by: Nghia Truong <[email protected]>

ttnghia added feature request New feature or request 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. Java Affects Java cuDF API. Spark Functionality that helps Spark RAPIDS non-breaking Non-breaking change labels Dec 20, 2024

ttnghia requested review from PointKernel and davidwendt December 20, 2024 19:25

ttnghia self-assigned this Dec 20, 2024

ttnghia requested review from a team as code owners December 20, 2024 19:25

ttnghia mentioned this pull request Dec 20, 2024

Hyper log log plus plus(HLL++) NVIDIA/spark-rapids-jni#2522

Open

Update docs

5982f3e

Signed-off-by: Nghia Truong <[email protected]>

PointKernel reviewed Dec 20, 2024

View reviewed changes

cpp/include/cudf/aggregation/host_udf.hpp Outdated Show resolved Hide resolved

cpp/include/cudf/aggregation/host_udf.hpp Outdated Show resolved Hide resolved

ttnghia added 12 commits December 23, 2024 19:03

Separate one base class into 4 base classes

edaa007

Signed-off-by: Nghia Truong <[email protected]>

Fix compile errors

07579d0

Signed-off-by: Nghia Truong <[email protected]>

Refactor the base classes

2a497e1

Signed-off-by: Nghia Truong <[email protected]>

Simplify the interface for reduction and segmented reduction

86ad3bb

Signed-off-by: Nghia Truong <[email protected]>

Rewrite tests

f27c9fd

Signed-off-by: Nghia Truong <[email protected]>

Merge branch 'branch-25.02' into host_udf_reduction

2deeb3b

Rewrite comments and reformat

41cf444

Signed-off-by: Nghia Truong <[email protected]>

Reformat

e4cabfd

Signed-off-by: Nghia Truong <[email protected]>

Change return type to const&

ca83ecf

Signed-off-by: Nghia Truong <[email protected]>

Fix docs

54a1e2d

Signed-off-by: Nghia Truong <[email protected]>

Fix inheritant property

b3e5ce6

Signed-off-by: Nghia Truong <[email protected]>

Fix forward declaration

9b3e4fb

Signed-off-by: Nghia Truong <[email protected]>

ttnghia added 2 commits January 7, 2025 10:21

Fix typo

c3b52da

Signed-off-by: Nghia Truong <[email protected]>

Remove unused header

89e8380

Signed-off-by: Nghia Truong <[email protected]>

ttnghia commented Jan 7, 2025

View reviewed changes

nvdbaranec requested changes Jan 8, 2025

View reviewed changes

ttnghia and others added 6 commits January 8, 2025 16:16

Update cpp/include/cudf/aggregation/host_udf.hpp

4f6d340

Co-authored-by: nvdbaranec <[email protected]>

Update cpp/include/cudf/aggregation/host_udf.hpp

9d9429a

Co-authored-by: nvdbaranec <[email protected]>

Change parameter order

76b5687

Signed-off-by: Nghia Truong <[email protected]>

Extract reduction and segmented reduction tests

38290ac

Signed-off-by: Nghia Truong <[email protected]>

Rename base classes

1cb656b

Signed-off-by: Nghia Truong <[email protected]>

Rewrite callbacks

78dc6a6

Signed-off-by: Nghia Truong <[email protected]>

ttnghia requested a review from a team as a code owner January 10, 2025 05:14

github-actions bot added the CMake CMake build issue label Jan 10, 2025

ttnghia and others added 4 commits January 9, 2025 21:22

Update copyright header

9810e6e

Signed-off-by: Nghia Truong <[email protected]>

Misc

cecb7f7

Signed-off-by: Nghia Truong <[email protected]>

Rename variables

1f24ab0

Signed-off-by: Nghia Truong <[email protected]>

Merge branch 'branch-25.02' into host_udf_reduction

a6b9699

sperlingxx reviewed Jan 10, 2025

View reviewed changes

revans2 approved these changes Jan 10, 2025

View reviewed changes

KyleFromNVIDIA approved these changes Jan 10, 2025

View reviewed changes

PointKernel approved these changes Jan 10, 2025

View reviewed changes

cpp/include/cudf/aggregation/host_udf.hpp Outdated Show resolved Hide resolved

ttnghia and others added 3 commits January 10, 2025 11:44

Update cpp/include/cudf/aggregation/host_udf.hpp

8b88982

Co-authored-by: Yunsong Wang <[email protected]>

Try to fix docs

ad96501

Signed-off-by: Nghia Truong <[email protected]>

Merge branch 'branch-25.02' into host_udf_reduction

b274eec

ttnghia requested a review from nvdbaranec January 10, 2025 19:26

ttnghia and others added 4 commits January 10, 2025 13:31

Try to fix docs build

4b7c874

Signed-off-by: Nghia Truong <[email protected]>

Test docs

76e3a87

Signed-off-by: Nghia Truong <[email protected]>

Try fixing docs

49b676a

Signed-off-by: Nghia Truong <[email protected]>

Minimal fix for doc builds plus some minor typo fixes

f68e7fd

github-actions bot assigned vyasr Jan 11, 2025

ttnghia unassigned vyasr Jan 11, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement `HOST_UDF` aggregation for reduction and segmented reduction #17645

Implement `HOST_UDF` aggregation for reduction and segmented reduction #17645

ttnghia commented Dec 20, 2024

ttnghia commented Dec 29, 2024 •

edited

Loading

ttnghia Jan 7, 2025 •

edited

Loading

sperlingxx Jan 10, 2025 •

edited

Loading

ttnghia Jan 10, 2025

revans2 left a comment

KyleFromNVIDIA left a comment

PointKernel left a comment

	public ColumnVector(DType type, long rows, Optional<Long> nullCount,
	DeviceMemoryBuffer dataBuffer, DeviceMemoryBuffer validityBuffer,
	DeviceMemoryBuffer offsetBuffer, List<DeviceMemoryBuffer> toClose, long[] childHandles) {

Implement HOST_UDF aggregation for reduction and segmented reduction #17645

Are you sure you want to change the base?

Implement HOST_UDF aggregation for reduction and segmented reduction #17645

Conversation

ttnghia commented Dec 20, 2024

ttnghia commented Dec 29, 2024 • edited Loading

ttnghia Jan 7, 2025 • edited Loading

Choose a reason for hiding this comment

sperlingxx Jan 10, 2025 • edited Loading

Choose a reason for hiding this comment

ttnghia Jan 10, 2025

Choose a reason for hiding this comment

revans2 left a comment

Choose a reason for hiding this comment

KyleFromNVIDIA left a comment

Choose a reason for hiding this comment

PointKernel left a comment

Choose a reason for hiding this comment

Implement `HOST_UDF` aggregation for reduction and segmented reduction #17645

Implement `HOST_UDF` aggregation for reduction and segmented reduction #17645

ttnghia commented Dec 29, 2024 •

edited

Loading

ttnghia Jan 7, 2025 •

edited

Loading

sperlingxx Jan 10, 2025 •

edited

Loading