Control pinned memory use with environment variables #17657
+4
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
vuule
added
feature request
|
/ok to test |
ttnghia
reviewed
Dec 25, 2024
| @@ -277,7 +279,7 @@ bool config_default_pinned_memory_resource(pinned_mr_options const& opts) | |||
| CUDF_EXPORT auto& kernel_pinned_copy_threshold() | |||
| { | |||
| // use cudaMemcpyAsync for all pinned copies | |||
| static std::atomic<size_t> threshold = 0; | |||
| static std::atomic<size_t> threshold = getenv_or("LIBCUDF_KERNEL_PINNED_COPY_THRESHOLD", 0); | |||
There was a problem hiding this comment.
One issue with static variable is that, they are initialized only once. The user will not be able to change them after they are set. Can we remove static?
There was a problem hiding this comment.
I'm torn on this one. You're right, but:
I really like reading the env var once so I can log it cleanly (already a part of getenv_or).
Also, there are (C++) APIs to set these thresholds at runtime.
I'd keep this static until we have a use case that requires runtime changes.
ttnghia
approved these changes
Dec 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds
LIBCUDF_KERNEL_PINNED_COPY_THRESHOLDandLIBCUDF_ALLOCATE_HOST_AS_PINNED_THRESHOLDenvironment variables to set the pinned memory optimizations' thresholds.Checklist