Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GCC 13 in CUDA 12 conda builds. #17721

Merged

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Jan 13, 2025

Description

conda-forge is using GCC 13 for CUDA 12 builds. This PR updates CUDA 12 conda builds to use GCC 13, for alignment.

These PRs should be merged in a specific order, see rapidsai/build-planning#129 for details.

@bdice bdice added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Jan 13, 2025
Copy link

copy-pr-bot bot commented Jan 13, 2025

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@bdice bdice added the DO NOT MERGE Hold off on merging; see PR for details label Jan 13, 2025
@bdice bdice marked this pull request as ready for review January 13, 2025 19:43
@bdice bdice requested a review from a team as a code owner January 13, 2025 19:43
@bdice bdice requested a review from AyodeAwe January 13, 2025 19:43
@jameslamb jameslamb requested review from jameslamb and removed request for AyodeAwe January 13, 2025 20:05
@jakirkham
Copy link
Member

Saw a few network errors (like this one). So restarted CI

@jakirkham
Copy link
Member

Seeing some errors on CI like the one below

Error: 1-14 03:57:17.596] [CUDF] [error] ORC writer encountered exception during processing. No data has been written to the sink.
unknown file: Failure
C++ exception with description "CUDF failure at:/opt/conda/conda-bld/work/cpp/src/io/orc/writer_impl.cu:533: Unsupported ORC type for RLE stream size" thrown in the test body.
[  FAILED  ] ORCTest.ORCWriter (1335 ms)

@bdice
Copy link
Contributor Author

bdice commented Jan 15, 2025

@vuule Could you help investigate these errors like Unsupported ORC type for RLE stream size, or delegate to someone else who can help? (I am chasing down some other build issues across RAPIDS.)

@vuule
Copy link
Contributor

vuule commented Jan 15, 2025

@vuule Could you help investigate these errors like Unsupported ORC type for RLE stream size, or delegate to someone else who can help? (I am chasing down some other build issues across RAPIDS.)

This again? #17534 fixed this issue on 25.02. @robertmaynard had to make an additional change for 24.10. My first guess is that we need to integrate this into 25.02 as well.

@jakirkham
Copy link
Member

jakirkham commented Jan 15, 2025

It looks like this PR is based off of commit: fdd4255

Would think that would have the change referenced as the commit above is from 2 days ago and the PR ( #17534 ) is from early December

Or am I missing something?

@robertmaynard
Copy link
Contributor

@vuule Could you help investigate these errors like Unsupported ORC type for RLE stream size, or delegate to someone else who can help? (I am chasing down some other build issues across RAPIDS.)

This again? #17534 fixed this issue on 25.02. @robertmaynard had to make an additional change for 24.10. My first guess is that we need to integrate this into 25.02 as well.

Yes I had to add usage of kind in the default case of size_t RLE_stream_size(TypeKind kind, size_t count) ( added it to message ).

@vuule vuule self-requested a review January 15, 2025 23:13
@vuule vuule requested a review from a team as a code owner January 15, 2025 23:16
@vuule vuule requested a review from nvdbaranec January 15, 2025 23:16
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Jan 15, 2025
@vuule
Copy link
Contributor

vuule commented Jan 16, 2025

omg that worked! At least we're consistent now.

@jakirkham
Copy link
Member

Thanks Vukasin and Rob! 🙏

Glad to see CI green 😄

@bdice bdice removed the DO NOT MERGE Hold off on merging; see PR for details label Jan 17, 2025
@bdice
Copy link
Contributor Author

bdice commented Jan 17, 2025

/merge

@rapids-bot rapids-bot bot merged commit 6293b70 into rapidsai:branch-25.02 Jan 17, 2025
107 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants