Deprecate dataframe protocol #17736
Open
Deprecate dataframe protocol #17736
+14
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyasr
added
improvement
Matt711
reviewed
Jan 14, 2025
| @@ -5562,6 +5563,12 @@ def from_pandas(cls, dataframe, nan_as_null=no_default): | |||
| elif hasattr(dataframe, "__dataframe__"): | |||
| # TODO: Probably should be handled in the constructor as | |||
| # this isn't pandas specific | |||
| assert version.parse(cudf.__version__) < version.parse("25.04.00") | |||
| warnings.warn( | |||
There was a problem hiding this comment.
Do we need to filter this warning too?
There was a problem hiding this comment.
We don't because that branch wasn't tested before 🙃 I thought about it but then skipped it since it's already untested and we're removing this code next release anyway.
Matt711
approved these changes
Jan 15, 2025
| @@ -5562,6 +5563,12 @@ def from_pandas(cls, dataframe, nan_as_null=no_default): | |||
| elif hasattr(dataframe, "__dataframe__"): | |||
| # TODO: Probably should be handled in the constructor as | |||
| # this isn't pandas specific | |||
| assert version.parse(cudf.__version__) < version.parse("25.04.00") | |||
| warnings.warn( | |||
galipremsagar
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #17403
Checklist