Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make more constexpr available on device for cuIO #17746

Merged
merged 27 commits into from
Jan 26, 2025
Merged

Make more constexpr available on device for cuIO #17746

merged 27 commits into from
Jan 26, 2025

Conversation

PointKernel
Copy link
Member

Description

Contributes to #7795

This PR addressed most of the relaxed constexpr in cuIO.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@PointKernel PointKernel added feature request New feature or request libcudf Affects libcudf (C++/CUDA) code. cuIO cuIO issue non-breaking Non-breaking change labels Jan 15, 2025
@PointKernel PointKernel self-assigned this Jan 15, 2025
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Jan 15, 2025

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@PointKernel
Copy link
Member Author

/ok to test

PointKernel
PointKernel commented Jan 15, 2025
View reviewed changes
cpp/include/cudf/utilities/span.hpp Outdated Show resolved Hide resolved
cpp/src/io/parquet/compact_protocol_reader.cpp Outdated Show resolved Hide resolved
cpp/src/io/parquet/parquet_gpu.hpp Show resolved Hide resolved
@PointKernel PointKernel added the 4 - Needs Review Waiting for reviewer to review or respond label Jan 15, 2025
@PointKernel PointKernel marked this pull request as ready for review January 15, 2025 18:58
@PointKernel PointKernel requested a review from a team as a code owner January 15, 2025 18:58
@PointKernel PointKernel requested review from vuule and lamarrr January 15, 2025 18:58
@kingcrimsontianyu kingcrimsontianyu self-requested a review January 15, 2025 22:03
@PointKernel PointKernel mentioned this pull request Jan 23, 2025
Open
vuule
vuule reviewed Jan 24, 2025
View reviewed changes
Copy link
Contributor

@vuule vuule left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few small comments/questions

cpp/src/io/parquet/page_decode.cuh Show resolved Hide resolved
cpp/src/io/parquet/delta_binary.cuh Show resolved Hide resolved
cpp/src/io/parquet/delta_binary.cuh Show resolved Hide resolved
cpp/include/cudf/strings/detail/strings_children.cuh Show resolved Hide resolved
vuule
vuule approved these changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@vuule vuule left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff!

@PointKernel
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit 551e452 into rapidsai:branch-25.02 Jan 26, 2025
106 of 107 checks passed
@PointKernel PointKernel deleted the cuio-relaxed-constexpr branch January 26, 2025 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etseidl etseidl etseidl left review comments

@lamarrr lamarrr lamarrr approved these changes

@vuule vuule vuule approved these changes

@kingcrimsontianyu kingcrimsontianyu Awaiting requested review from kingcrimsontianyu

Assignees

@PointKernel PointKernel

Labels
4 - Needs Review Waiting for reviewer to review or respond cuIO cuIO issue feature request New feature or request libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
libcudf
Status: Landed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@PointKernel @vuule @etseidl @lamarrr