Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pre-commit.ci failures #17819

Merged
merged 2 commits into from
Jan 27, 2025
Merged

Fix pre-commit.ci failures #17819

merged 2 commits into from
Jan 27, 2025

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Jan 24, 2025

Description

This PR fixes pre-commit.ci failures.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@bdice bdice requested a review from a team as a code owner January 24, 2025 21:33
@bdice bdice requested a review from KyleFromNVIDIA January 24, 2025 21:33
@davidwendt
Copy link
Contributor

Not sure if this trying to address the same problem #17805

@bdice bdice added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jan 24, 2025
@bdice
Copy link
Contributor Author

bdice commented Jan 24, 2025

I'm going to merge this to make pre-commit.ci pass by ignoring the failing check.

Then I will work with @Matt711 on #17805 for a proper long-term fix (migrating from nbqa-isort to nbqa-ruff-check and nbqa-ruff-format).

@bdice
Copy link
Contributor Author

bdice commented Jan 24, 2025

/merge

@bdice bdice mentioned this pull request Jan 24, 2025
Merged
3 tasks
@bdice
Copy link
Contributor Author

bdice commented Jan 26, 2025

Network failure:

WARNING: failed to reach any of the inventories with the following issues:
intersphinx inventory 'https://dmlc.github.io/dlpack/latest/objects.inv' not fetchable due to <class 'requests.exceptions.ConnectionError'>: ('Connection aborted.', ConnectionResetError(104, 'Connection reset by peer'))

Rerunning docs-build again.

@AyodeAwe AyodeAwe merged commit 03e1f64 into rapidsai:branch-25.02 Jan 27, 2025
18 of 29 checks passed
rapids-bot bot pushed a commit that referenced this pull request Jan 28, 2025
@bdice
Apply ruff everywhere (notebooks and scripts) (#17820)
87c8ab3 
This PR applies `ruff` (`check` and `format`) everywhere, including notebooks and utility scripts. This allows us to drop our use of `nbqa`, since `ruff` natively supports notebooks. (xref: #17819, #17805)

I manually updated a few notebooks that were using old NumPy syntax for generating random values.
Closes #17461.

I also updated the `ruff` version to 0.9.3.

Authors:
  - Bradley Dice (https://github.com/bdice)
  - Vyas Ramasubramani (https://github.com/vyasr)

Approvers:
  - Vyas Ramasubramani (https://github.com/vyasr)
  - Matthew Murray (https://github.com/Matt711)

URL: #17820
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KyleFromNVIDIA KyleFromNVIDIA KyleFromNVIDIA approved these changes

Assignees

@vyasr vyasr

@bdice bdice

Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bdice @davidwendt @KyleFromNVIDIA @vyasr @AyodeAwe