-
Notifications
You must be signed in to change notification settings - Fork 928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply ruff everywhere (notebooks and scripts) #17820
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
c8ac9c5
Update ruff and allow it to act on notebooks.
bdice 0da2d64
Apply ruff everywhere.
bdice 7e8286a
Ignore E711 in missing-data.ipynb
bdice 8b86c89
Merge remote-tracking branch 'upstream/branch-25.02' into ruff-notebooks
bdice 79b08f7
Revert skip of nbqa-isort (no longer needed).
bdice 05aca1c
Merge branch 'branch-25.02' into ruff-notebooks
vyasr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,24 +1,34 @@ | ||
# Copyright (c) 2024, NVIDIA CORPORATION. | ||
# Copyright (c) 2024-2025, NVIDIA CORPORATION. | ||
|
||
import argparse | ||
|
||
import requests | ||
from packaging.version import Version | ||
from packaging.specifiers import SpecifierSet | ||
import argparse | ||
from packaging.version import Version | ||
|
||
|
||
def get_pandas_versions(pandas_range): | ||
url = "https://pypi.org/pypi/pandas/json" | ||
response = requests.get(url) | ||
data = response.json() | ||
versions = [Version(v) for v in data['releases']] | ||
versions = [Version(v) for v in data["releases"]] | ||
specifier = SpecifierSet(pandas_range.lstrip("pandas")) | ||
matching_versions = [v for v in versions if v in specifier] | ||
matching_minors = sorted(set(".".join((str(v.major), str(v.minor))) for v in matching_versions), key=Version) | ||
matching_minors = sorted( | ||
set(".".join((str(v.major), str(v.minor))) for v in matching_versions), | ||
key=Version, | ||
) | ||
return matching_minors | ||
|
||
|
||
if __name__ == "__main__": | ||
parser = argparse.ArgumentParser(description="Filter pandas versions by prefix.") | ||
parser.add_argument("pandas_range", type=str, help="The version prefix to filter by.") | ||
parser = argparse.ArgumentParser( | ||
description="Filter pandas versions by prefix." | ||
) | ||
parser.add_argument( | ||
"pandas_range", type=str, help="The version prefix to filter by." | ||
) | ||
args = parser.parse_args() | ||
|
||
versions = get_pandas_versions(args.pandas_range) | ||
print(','.join(versions)) | ||
print(",".join(versions)) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In #17461, @wence- were you trying to say you are hesitant to apply
ruff
without a config for sortingcudf
into a separate section? I am okay with the diff shown here, but if you're not, I wanted to let you opine. We could use an import section config of some kind, but I find it unimportant in notebooks (only within the library internals).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just meant that we didn't port the isort config for notebooks over. I am happy with any consistent sorting!