Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass more dtype objects to astype calls #18044

Merged
merged 2 commits into from
Feb 20, 2025
Merged

Pass more dtype objects to astype calls #18044

merged 2 commits into from
Feb 20, 2025

Conversation

mroeschke
Copy link
Contributor

Description

Broken off from #17978

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke added Python Affects Python cuDF API. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Feb 19, 2025
@mroeschke mroeschke self-assigned this Feb 19, 2025
@mroeschke mroeschke requested a review from a team as a code owner February 19, 2025 21:03
Matt711
Matt711 approved these changes Feb 19, 2025
View reviewed changes
Copy link
Contributor

@Matt711 Matt711 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, one non-blocking question

@mroeschke
Copy link
Contributor Author

/merge

1 similar comment
@mroeschke
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit eb5c309 into rapidsai:branch-25.04 Feb 20, 2025
109 checks passed
@mroeschke mroeschke deleted the cln/dtype/obj/2 branch February 20, 2025 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Matt711 Matt711 Matt711 approved these changes

@galipremsagar galipremsagar Awaiting requested review from galipremsagar galipremsagar is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@mroeschke mroeschke

Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
cuDF Python
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mroeschke @Matt711