Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make external vertex and edge shuffling function public #4227

Merged
merged 9 commits into from
Mar 12, 2024
Merged

Make external vertex and edge shuffling function public #4227

merged 9 commits into from
Mar 12, 2024

Conversation

naimnv
Copy link
Contributor

@naimnv naimnv commented Mar 9, 2024

Make vertex and edge shuffling function public

@naimnv naimnv requested a review from a team as a code owner March 9, 2024 01:25
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Mar 9, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@naimnv naimnv self-assigned this Mar 9, 2024
@naimnv naimnv added this to the 24.04 milestone Mar 9, 2024
@naimnv naimnv added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Mar 9, 2024
@naimnv
Copy link
Contributor Author

naimnv commented Mar 9, 2024

/okay to test

@naimnv
Copy link
Contributor Author

naimnv commented Mar 11, 2024

/okay to test

@naimnv naimnv changed the title Make vertex and edge shuffling function public Make external vertex and edge shuffling function public Mar 11, 2024
seunghwak
seunghwak reviewed Mar 11, 2024
View reviewed changes
Copy link
Contributor

@seunghwak seunghwak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me in general but I have few minor suggestions about code cosmetics.

cpp/include/cugraph/graph_functions.hpp Outdated Show resolved Hide resolved
cpp/include/cugraph/graph_functions.hpp Outdated Show resolved Hide resolved
cpp/src/detail/shuffle_vertices.cu Show resolved Hide resolved
@naimnv naimnv requested a review from a team as a code owner March 11, 2024 21:14
@github-actions github-actions bot added the CMake label Mar 11, 2024
@naimnv
Copy link
Contributor Author

naimnv commented Mar 11, 2024

/okay to test

seunghwak
seunghwak approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@seunghwak seunghwak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ChuckHastings
Copy link
Collaborator

/merge

@rapids-bot rapids-bot bot merged commit e4b58ec into rapidsai:branch-24.04 Mar 12, 2024
142 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seunghwak seunghwak seunghwak approved these changes

@ChuckHastings ChuckHastings ChuckHastings approved these changes

Assignees

@naimnv naimnv

Labels
CMake cuGraph improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
24.04
Development

Successfully merging this pull request may close these issues.
4 participants
@naimnv @ChuckHastings @seunghwak @nv-rliu