Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update API for node2vec and biased random walks #4841

Open
wants to merge 72 commits into
base: branch-25.02
Choose a base branch
from

Conversation

jnke2016
Copy link
Contributor

@jnke2016 jnke2016 commented Dec 28, 2024

This PR

  1. Add MG support for node2vec random walks on the C, PLC and Python API
  2. Fix renumbering bug in the CAPI for node2vec and biased random walks
  3. Enable and fix bug in the MG C tests
  4. Deprecate legacy node2vec and uniform random walks
  5. Add SG and MG support for Biased random walks
  6. Add multi GPU support for ECG in the python API

closes #3277
closes #2558
closes #2559
closes #2560
closes #2561
closes #2853
closes #4843

@jnke2016 jnke2016 requested a review from rlratzel January 16, 2025 18:49
@jnke2016 jnke2016 force-pushed the branch-25.02_node2vec-random-walks branch from b5072df to e719607 Compare January 30, 2025 23:33
@ChuckHastings ChuckHastings added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Feb 4, 2025
Copy link
Contributor

@rlratzel rlratzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the Python parts. I had just a few optional suggestions.

>>> M = karate.get_edgelist(download=True)
>>> G = karate.get_graph()
>>> start_vertices = G.nodes()[:4]
>>> _, _, _ = cugraph.biased_random_walks(G, start_vertices, 3)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bit strange. Maybe consider showing the results somehow.

Comment on lines 115 to 117
warning_msg = (
"node2vec is deprecated and will be removed "
"in the next release in favor of node2vec_random_walks"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
warning_msg = (
"node2vec is deprecated and will be removed "
"in the next release in favor of node2vec_random_walks"
warning_msg = (
"node2vec is deprecated and will be removed "
"in a future release in favor of node2vec_random_walks"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMake cuGraph improvement Improvement / enhancement to an existing function non-breaking Non-breaking change python
Projects
None yet
3 participants