-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update API for node2vec and biased random walks #4841
base: branch-25.02
Are you sure you want to change the base?
Update API for node2vec and biased random walks #4841
Conversation
…2_node2vec-random-walks
…2_node2vec-random-walks
…2_node2vec-random-walks
…2_node2vec-random-walks
…2_node2vec-random-walks
b5072df
to
e719607
Compare
…2_node2vec-random-walks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed the Python parts. I had just a few optional suggestions.
>>> M = karate.get_edgelist(download=True) | ||
>>> G = karate.get_graph() | ||
>>> start_vertices = G.nodes()[:4] | ||
>>> _, _, _ = cugraph.biased_random_walks(G, start_vertices, 3) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a bit strange. Maybe consider showing the results somehow.
warning_msg = ( | ||
"node2vec is deprecated and will be removed " | ||
"in the next release in favor of node2vec_random_walks" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning_msg = ( | |
"node2vec is deprecated and will be removed " | |
"in the next release in favor of node2vec_random_walks" | |
warning_msg = ( | |
"node2vec is deprecated and will be removed " | |
"in a future release in favor of node2vec_random_walks" |
This PR
closes #3277
closes #2558
closes #2559
closes #2560
closes #2561
closes #2853
closes #4843