Include a thrust header that was missing to use thrust::max #4867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpp/tests/utilities/check_utilities.hpp: In member function ‘bool cugraph::test::device_nearly_equal<type_t>::operator()(type_t, type_t) const’: cpp/tests/utilities/check_utilities.hpp:98:20: error: ‘max’ is not a member of ‘thrust’ 98 | thrust::max(thrust::max(lhs, rhs) * threshold_ratio, threshold_magnitude); | ^~~
|
/ok to test |
ChuckHastings
added
bug
ChuckHastings
approved these changes
Jan 17, 2025
There was a problem hiding this comment.
Need to update the copyright date on the file.
|
Per discussions with @seunghwak an even better solution is to get rid of thrust::max and use (cuda::)std::max nowadays |
|
#4871 should replace this PR. |
|
Closed in favor of #4871 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The <thrust/extrema.h> header is needed to use thrust::max so we include it to avoid this error
cpp/tests/utilities/check_utilities.hpp: In member function ‘bool cugraph::test::device_nearly_equal<type_t>::operator()(type_t, type_t) const’:
cpp/tests/utilities/check_utilities.hpp:98:20: error: ‘max’ is not a member of ‘thrust’
98 | thrust::max(thrust::max(lhs, rhs) * threshold_ratio, threshold_magnitude);
| ^~~