Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use wildcards in auditwheel exclusions #4877

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

jameslamb
Copy link
Member

@jameslamb jameslamb commented Jan 22, 2025

Contributes to rapidsai/build-planning#137

Follow-up to #4804

Wheel builds here currently list out some shared library to exclude in auditwheel repair, which they pick up transitively via linking to libraft.

EXCLUDE_ARGS+=(
--exclude "libcublas.so.12"
--exclude "libcublasLt.so.12"
--exclude "libcurand.so.10"
--exclude "libcusolver.so.11"
--exclude "libcusparse.so.12"
--exclude "libnvJitLink.so.12"
)

The version components of those library names can change when those libraries have ABI breakages, for example across CUDA major version boundaries. This proposes replacing specific versions with wildcards, to exclude all versions of those libraries.

Notes for Reviewers

This is especially relevant given this: rapidsai/raft#2548

For example, the latest nvidia-cublas-cu11 has libcublas.so.11 while nvidia-cublas-cu12 has libcublas.so.12.

Copy link

copy-pr-bot bot commented Jan 22, 2025

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@jameslamb
Copy link
Member Author

/ok to test

@github-actions github-actions bot added the ci label Jan 22, 2025
@jameslamb jameslamb added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jan 22, 2025
@jameslamb jameslamb changed the title WIP: use wildcards in auditwheel exclusions use wildcards in auditwheel exclusions Jan 22, 2025
@jameslamb jameslamb requested a review from bdice January 22, 2025 01:18
@jameslamb jameslamb marked this pull request as ready for review January 22, 2025 01:18
@jameslamb jameslamb requested a review from a team as a code owner January 22, 2025 01:18
@bdice
Copy link
Contributor

bdice commented Jan 22, 2025

/merge

@rapids-bot rapids-bot bot merged commit 9396bbb into rapidsai:branch-25.02 Jan 22, 2025
81 checks passed
@jameslamb jameslamb deleted the dynamic-cuda-wheels branch January 22, 2025 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants