use wildcards in auditwheel exclusions #4877
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to rapidsai/build-planning#137
Follow-up to #4804
Wheel builds here currently list out some shared library to exclude in
auditwheel repair
, which they pick up transitively via linking tolibraft
.cugraph/ci/build_wheel.sh
Lines 42 to 49 in a9c923b
The version components of those library names can change when those libraries have ABI breakages, for example across CUDA major version boundaries. This proposes replacing specific versions with wildcards, to exclude all versions of those libraries.
Notes for Reviewers
This is especially relevant given this: rapidsai/raft#2548
For example, the latest
nvidia-cublas-cu11
haslibcublas.so.11
whilenvidia-cublas-cu12
haslibcublas.so.12
.