Introduce options to disable some algorithms in cmake and reduce compilation time #4883
Conversation
cpp/tests/CMakeLists.txt
Outdated
| @@ -330,6 +330,7 @@ ConfigureTest(GRAPH_GENERATORS_TEST generators/generators_test.cpp) | |||
| # - erdos renyi graph generator tests ------------------------------------------------------------- | |||
| ConfigureTest(ERDOS_RENYI_GENERATOR_TEST generators/erdos_renyi_test.cpp) | |||
|
|
|||
| if (BUILD_CUGRAPH_COMMUNITY_ALGORITHMS) | |||
There was a problem hiding this comment.
Maybe we prefer something like defining "tags" to avoid the mess with if(...) endif() which can easily get out of sync or unmaintained.
ConfigureTest(LOUVAIN_TEST COMMUNITY community/louvain_test.cpp)
Then filter tests in ConfigureTest depending on that tag
There was a problem hiding this comment.
Putting the filter in ConfigureTest seems like it would be easier to be sure to get things configured properly.
There was a problem hiding this comment.
And i'll create a "COMMON" class too for everything that's always there
| ) | ||
| endif() | ||
|
|
||
| if (BUILD_CUGRAPH_CENTRALITY_ALGORITHMS) |
There was a problem hiding this comment.
maybe it's cleaner to define CUGRAPH_CENTRALITY_SOURCES, CUGRAPH_COMMON_SOURCES, etc.... and then append at the end ?
There was a problem hiding this comment.
This seems cleaner to me. Define CUGRAPH_CENTRALITY_SOURCES as empty if BUILD_CUGRAPH_CENTRALITY_ALGORITHMS is not defined, define it with the actual sources if it is defined. Then when you fill in CUGRAPH_SOURCES you can just include the variable ${CUGRAPH_CENTRALITY_SOURCES} in its definition.
No description provided.