Replace all uses of thrust::optional with cuda::std::optional
#4891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChuckHastings
approved these changes
Jan 23, 2025
There was a problem hiding this comment.
Thanks for this update.
I identified several files, tagged with comments, where it looks like we could just drop the include file rather than changing it. If you're willing to make those changes (and they compile) that would be great. If you'd rather we do that, I can put it on the list to review those changes in 25.04.
cpp/src/sampling/detail/remove_visited_vertices_from_frontier.cuh
Outdated
Show resolved
Hide resolved
cpp/src/sampling/detail/remove_visited_vertices_from_frontier_sg_v32_e32.cu
Outdated
Show resolved
Hide resolved
cpp/src/sampling/detail/remove_visited_vertices_from_frontier_sg_v64_e64.cu
Outdated
Show resolved
Hide resolved
ChuckHastings
added
improvement
|
@ChuckHastings Thanks a lot for the review. I went ahead and checked those files. It seems that those were actually using |
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
thrust::optionalis being deprecated and will be removed in a future version of CCCL