Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Experimental command line interface UX #6135
Experimental command line interface UX #6135
Changes from 30 commits
d63e222
4a1a7bc
9eb0255
1086f75
abf81bd
f43e580
c902164
00c14d6
d46c31d
24a8047
009546c
9c3edce
502886b
5c441a3
15ac83d
7b8fdd4
33c6a7e
20c345b
cb2234d
4f5e7c5
4e193d0
5772e0d
881ada1
b32495d
26f64ad
de51949
510da44
dfa7828
cd84519
f4d78c7
a599330
43a7f7a
0730087
d5d64db
38ab735
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So the no-code change magic kicks in when running the pytest suite? Very cool.
By the way, does it affect the other pytests that are outside
cuml.experimental.accel
? Many of our existing tests assert that cuML algorithm matches output of sklearn's counterpart.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It only affects pytests that are run with the
-p
flagpytest -p cuml.experimental.accel ...