Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to NVKS for amd64 CI runners #6280

Merged
merged 4 commits into from
Feb 3, 2025
Merged

Migrate to NVKS for amd64 CI runners #6280

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f0fc986
Migrate to NVKS for amd64 CI runners
bdice Jan 30, 2025
71d7e07
Merge branch 'branch-25.04' into nvks-runners
bdice Jan 31, 2025
6bfb1d0
Merge branch 'branch-25.04' into nvks-runners
jameslamb Jan 31, 2025
8a92b6a
Remove check that different seeds give different results.
bdice Feb 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions .github/workflows/build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ concurrency:
jobs:
cpp-build:
secrets: inherit
uses: rapidsai/shared-workflows/.github/workflows/conda-cpp-build.yaml@branch-25.04
uses: rapidsai/shared-workflows/.github/workflows/conda-cpp-build.yaml@nvks-runners
with:
build_type: ${{ inputs.build_type || 'branch' }}
branch: ${{ inputs.branch }}
Expand All @@ -38,20 +38,20 @@ jobs:
if: github.ref_type == 'branch'
needs: [python-build]
secrets: inherit
uses: rapidsai/shared-workflows/.github/workflows/custom-job.yaml@branch-25.04
uses: rapidsai/shared-workflows/.github/workflows/custom-job.yaml@nvks-runners
with:
arch: "amd64"
branch: ${{ inputs.branch }}
build_type: ${{ inputs.build_type || 'branch' }}
container_image: "rapidsai/ci-conda:latest"
date: ${{ inputs.date }}
node_type: "gpu-v100-latest-1"
node_type: "gpu-l4-latest-1"
run_script: "ci/build_docs.sh"
sha: ${{ inputs.sha }}
python-build:
needs: [cpp-build]
secrets: inherit
uses: rapidsai/shared-workflows/.github/workflows/conda-python-build.yaml@branch-25.04
uses: rapidsai/shared-workflows/.github/workflows/conda-python-build.yaml@nvks-runners
with:
build_type: ${{ inputs.build_type || 'branch' }}
branch: ${{ inputs.branch }}
Expand All @@ -60,15 +60,15 @@ jobs:
upload-conda:
needs: [cpp-build, python-build]
secrets: inherit
uses: rapidsai/shared-workflows/.github/workflows/conda-upload-packages.yaml@branch-25.04
uses: rapidsai/shared-workflows/.github/workflows/conda-upload-packages.yaml@nvks-runners
with:
build_type: ${{ inputs.build_type || 'branch' }}
branch: ${{ inputs.branch }}
date: ${{ inputs.date }}
sha: ${{ inputs.sha }}
wheel-build-libcuml:
secrets: inherit
uses: rapidsai/shared-workflows/.github/workflows/wheels-build.yaml@branch-25.04
uses: rapidsai/shared-workflows/.github/workflows/wheels-build.yaml@nvks-runners
with:
build_type: ${{ inputs.build_type || 'branch' }}
branch: ${{ inputs.branch }}
Expand Down Expand Up @@ -107,7 +107,7 @@ jobs:
wheel-publish-cuml:
needs: wheel-build-cuml
secrets: inherit
uses: rapidsai/shared-workflows/.github/workflows/wheels-publish.yaml@branch-25.04
uses: rapidsai/shared-workflows/.github/workflows/wheels-publish.yaml@nvks-runners
with:
build_type: ${{ inputs.build_type || 'branch' }}
branch: ${{ inputs.branch }}
Expand Down
36 changes: 18 additions & 18 deletions .github/workflows/pr.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:
- wheel-tests-cuml
- devcontainer
secrets: inherit
uses: rapidsai/shared-workflows/.github/workflows/pr-builder.yaml@branch-25.04
uses: rapidsai/shared-workflows/.github/workflows/pr-builder.yaml@nvks-runners
if: always()
with:
needs: ${{ toJSON(needs) }}
Expand All @@ -46,7 +46,7 @@ jobs:
changed-files:
secrets: inherit
needs: telemetry-setup
uses: rapidsai/shared-workflows/.github/workflows/changed-files.yaml@branch-25.04
uses: rapidsai/shared-workflows/.github/workflows/changed-files.yaml@nvks-runners
with:
files_yaml: |
test_cpp:
Expand Down Expand Up @@ -80,15 +80,15 @@ jobs:
checks:
secrets: inherit
needs: telemetry-setup
uses: rapidsai/shared-workflows/.github/workflows/checks.yaml@branch-25.04
uses: rapidsai/shared-workflows/.github/workflows/checks.yaml@nvks-runners
with:
enable_check_generated_files: false
ignored_pr_jobs: >-
optional-job-conda-python-tests-cudf-pandas-integration telemetry-summarize
clang-tidy:
needs: checks
secrets: inherit
uses: rapidsai/shared-workflows/.github/workflows/custom-job.yaml@branch-25.04
uses: rapidsai/shared-workflows/.github/workflows/custom-job.yaml@nvks-runners
with:
build_type: pull-request
node_type: "cpu8"
Expand All @@ -98,41 +98,41 @@ jobs:
conda-cpp-build:
needs: checks
secrets: inherit
uses: rapidsai/shared-workflows/.github/workflows/conda-cpp-build.yaml@branch-25.04
uses: rapidsai/shared-workflows/.github/workflows/conda-cpp-build.yaml@nvks-runners
with:
build_type: pull-request
conda-cpp-tests:
needs: [conda-cpp-build, changed-files]
secrets: inherit
uses: rapidsai/shared-workflows/.github/workflows/conda-cpp-tests.yaml@branch-25.04
uses: rapidsai/shared-workflows/.github/workflows/conda-cpp-tests.yaml@nvks-runners
if: fromJSON(needs.changed-files.outputs.changed_file_groups).test_cpp
with:
build_type: pull-request
conda-cpp-checks:
needs: conda-cpp-build
secrets: inherit
uses: rapidsai/shared-workflows/.github/workflows/conda-cpp-post-build-checks.yaml@branch-25.04
uses: rapidsai/shared-workflows/.github/workflows/conda-cpp-post-build-checks.yaml@nvks-runners
with:
build_type: pull-request
enable_check_symbols: true
conda-python-build:
needs: conda-cpp-build
secrets: inherit
uses: rapidsai/shared-workflows/.github/workflows/conda-python-build.yaml@branch-25.04
uses: rapidsai/shared-workflows/.github/workflows/conda-python-build.yaml@nvks-runners
with:
build_type: pull-request
conda-python-tests-singlegpu:
needs: [conda-python-build, changed-files]
secrets: inherit
uses: rapidsai/shared-workflows/.github/workflows/conda-python-tests.yaml@branch-25.04
uses: rapidsai/shared-workflows/.github/workflows/conda-python-tests.yaml@nvks-runners
if: fromJSON(needs.changed-files.outputs.changed_file_groups).test_python
with:
build_type: pull-request
script: "ci/test_python_singlegpu.sh"
optional-job-conda-python-tests-cudf-pandas-integration:
needs: [conda-python-build, changed-files]
secrets: inherit
uses: rapidsai/shared-workflows/.github/workflows/conda-python-tests.yaml@branch-25.04
uses: rapidsai/shared-workflows/.github/workflows/conda-python-tests.yaml@nvks-runners
if: fromJSON(needs.changed-files.outputs.changed_file_groups).test_python
with:
matrix_filter: map(select(.ARCH == "amd64"))
Expand All @@ -141,36 +141,36 @@ jobs:
conda-python-tests-dask:
needs: [conda-python-build, changed-files]
secrets: inherit
uses: rapidsai/shared-workflows/.github/workflows/conda-python-tests.yaml@branch-25.04
uses: rapidsai/shared-workflows/.github/workflows/conda-python-tests.yaml@nvks-runners
if: fromJSON(needs.changed-files.outputs.changed_file_groups).test_python
with:
build_type: pull-request
script: "ci/test_python_dask.sh"
conda-notebook-tests:
needs: [conda-python-build, changed-files]
secrets: inherit
uses: rapidsai/shared-workflows/.github/workflows/custom-job.yaml@branch-25.04
uses: rapidsai/shared-workflows/.github/workflows/custom-job.yaml@nvks-runners
if: fromJSON(needs.changed-files.outputs.changed_file_groups).test_notebooks
with:
build_type: pull-request
node_type: "gpu-v100-latest-1"
node_type: "gpu-l4-latest-1"
arch: "amd64"
container_image: "rapidsai/ci-conda:latest"
run_script: "ci/test_notebooks.sh"
docs-build:
needs: conda-python-build
secrets: inherit
uses: rapidsai/shared-workflows/.github/workflows/custom-job.yaml@branch-25.04
uses: rapidsai/shared-workflows/.github/workflows/custom-job.yaml@nvks-runners
with:
build_type: pull-request
node_type: "gpu-v100-latest-1"
node_type: "gpu-l4-latest-1"
arch: "amd64"
container_image: "rapidsai/ci-conda:latest"
run_script: "ci/build_docs.sh"
wheel-build-libcuml:
needs: checks
secrets: inherit
uses: rapidsai/shared-workflows/.github/workflows/wheels-build.yaml@branch-25.04
uses: rapidsai/shared-workflows/.github/workflows/wheels-build.yaml@nvks-runners
with:
build_type: pull-request
branch: ${{ inputs.branch }}
Expand All @@ -192,15 +192,15 @@ jobs:
wheel-tests-cuml:
needs: [wheel-build-cuml, changed-files]
secrets: inherit
uses: rapidsai/shared-workflows/.github/workflows/wheels-test.yaml@branch-25.04
uses: rapidsai/shared-workflows/.github/workflows/wheels-test.yaml@nvks-runners
if: fromJSON(needs.changed-files.outputs.changed_file_groups).test_python
with:
build_type: pull-request
script: ci/test_wheel.sh
devcontainer:
needs: telemetry-setup
secrets: inherit
uses: rapidsai/shared-workflows/.github/workflows/build-in-devcontainer.yaml@branch-25.04
uses: rapidsai/shared-workflows/.github/workflows/build-in-devcontainer.yaml@nvks-runners
with:
arch: '["amd64"]'
cuda: '["12.8"]'
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ on:
jobs:
conda-cpp-checks:
secrets: inherit
uses: rapidsai/shared-workflows/.github/workflows/conda-cpp-post-build-checks.yaml@branch-25.04
uses: rapidsai/shared-workflows/.github/workflows/conda-cpp-post-build-checks.yaml@nvks-runners
with:
build_type: nightly
branch: ${{ inputs.branch }}
Expand All @@ -26,15 +26,15 @@ jobs:
symbol_exclusions: raft_cutlass
conda-cpp-tests:
secrets: inherit
uses: rapidsai/shared-workflows/.github/workflows/conda-cpp-tests.yaml@branch-25.04
uses: rapidsai/shared-workflows/.github/workflows/conda-cpp-tests.yaml@nvks-runners
with:
build_type: nightly
branch: ${{ inputs.branch }}
date: ${{ inputs.date }}
sha: ${{ inputs.sha }}
conda-python-tests-singlegpu:
secrets: inherit
uses: rapidsai/shared-workflows/.github/workflows/conda-python-tests.yaml@branch-25.04
uses: rapidsai/shared-workflows/.github/workflows/conda-python-tests.yaml@nvks-runners
with:
build_type: nightly
branch: ${{ inputs.branch }}
Expand All @@ -43,7 +43,7 @@ jobs:
script: "ci/test_python_singlegpu.sh"
conda-python-tests-dask:
secrets: inherit
uses: rapidsai/shared-workflows/.github/workflows/conda-python-tests.yaml@branch-25.04
uses: rapidsai/shared-workflows/.github/workflows/conda-python-tests.yaml@nvks-runners
with:
build_type: nightly
branch: ${{ inputs.branch }}
Expand All @@ -52,7 +52,7 @@ jobs:
script: "ci/test_python_dask.sh"
wheel-tests-cuml:
secrets: inherit
uses: rapidsai/shared-workflows/.github/workflows/wheels-test.yaml@branch-25.04
uses: rapidsai/shared-workflows/.github/workflows/wheels-test.yaml@nvks-runners
with:
build_type: nightly
branch: ${{ inputs.branch }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/trigger-breaking-change-alert.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
trigger-notifier:
if: contains(github.event.pull_request.labels.*.name, 'breaking')
secrets: inherit
uses: rapidsai/shared-workflows/.github/workflows/breaking-change-alert.yaml@branch-25.04
uses: rapidsai/shared-workflows/.github/workflows/breaking-change-alert.yaml@nvks-runners
with:
sender_login: ${{ github.event.sender.login }}
sender_avatar: ${{ github.event.sender.avatar_url }}
Expand Down
5 changes: 1 addition & 4 deletions python/cuml/cuml/tests/experimental/accel/estimators_hyperparams/test_accel_kmeans.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#
# Copyright (c) 2024, NVIDIA CORPORATION.
# Copyright (c) 2024-2025, NVIDIA CORPORATION.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -100,6 +100,3 @@ def test_kmeans_random_state(clustering_data):
kmeans2 = KMeans(n_clusters=3, random_state=42).fit(X)
# With the same random_state, results should be the same
assert np.allclose(kmeans1.cluster_centers_, kmeans2.cluster_centers_)
kmeans3 = KMeans(n_clusters=3, random_state=24).fit(X)
# With different random_state, results might differ
assert not np.allclose(kmeans1.cluster_centers_, kmeans3.cluster_centers_)
Comment on lines -103 to -105
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it makes sense to remove this part of the test. It is a bit unclear what it is trying to check because the cluster centers might or might not be the same if we use a different seed. This means that all we can assert here is maybe_allclose, which doesn't seem like a useful assertion.

So 👍 to removing it

Loading