Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: disallow fallback to Make in Python builds #1529

Draft
wants to merge 1 commit into
base: branch-25.04
Choose a base branch
from
Draft

WIP: disallow fallback to Make in Python builds #1529

wants to merge 1 commit into from

Conversation

jameslamb
Copy link
Member

Description

Contributes to rapidsai/build-planning#146

Proposes:

  • setting [tool.scikit-build].ninja.make-fallback = false, so scikit-build-core will not silently fallback to using GNU Make if ninja is not available

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@jameslamb jameslamb added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jan 31, 2025
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Jan 31, 2025

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@jameslamb jameslamb mentioned this pull request Jan 31, 2025
Open
@github-actions github-actions bot added the Python Related to Python code label Jan 31, 2025
@jameslamb jameslamb changed the title WIP: disallow fallback to Make in wheel builds WIP: disallow fallback to Make in Python builds Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Related to Python code
Projects
cuSpatial
Status: Todo
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jameslamb