Use GCC 13 in CUDA 12 conda builds. #567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdice
added
non-breaking
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
jameslamb
approved these changes
Jan 13, 2025
There was a problem hiding this comment.
Approving the packaging changes, assuming the fix for this build issue will be small and/or reviewed by C++ codeowners:
/opt/conda/conda-bld/work/cpp/src/neighbors/detail/dynamic_batching.cuh: In constructor 'constexpr cuvs::neighbors::dynamic_batching::detail::batch_token::batch_token(uint32_t)':
/opt/conda/conda-bld/work/cpp/src/neighbors/detail/dynamic_batching.cuh:242:62: error: call to non-'constexpr' function 'uint32_t& cuvs::neighbors::dynamic_batching::detail::batch_token::id()' [-Werror=invalid-constexpr]
242 | explicit constexpr inline batch_token(uint32_t buffer_id) { id() = buffer_id; }
| ~~~~~~~~^~
/opt/conda/conda-bld/work/cpp/src/neighbors/detail/dynamic_batching.cuh:258:1: note: 'uint32_t& cuvs::neighbors::dynamic_batching::detail::batch_token::id()' declared here
258 | RAFT_INLINE_FUNCTION auto id() noexcept -> uint32_t&
| ^
|
Thanks, here's the fix #582 |
bdice
commented
Jan 16, 2025
Comment on lines
+317
to
+318
| std::shared_ptr<KVP[]> exp_h(new KVP[size]); | ||
| std::shared_ptr<KVP[]> act_h(new KVP[size]); |
There was a problem hiding this comment.
This is needed so that new[] matches with delete[]. Without this, the deleter uses delete instead of delete[] and compilation fails.
divyegala
approved these changes
Jan 17, 2025
|
/merge |
cjnolet
approved these changes
Jan 17, 2025
|
I'm okay admin merging this |
|
Thanks all! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
conda-forge is using GCC 13 for CUDA 12 builds. This PR updates CUDA 12 conda builds to use GCC 13, for alignment.
These PRs should be merged in a specific order, see rapidsai/build-planning#129 for details.
Closes rapidsai/build-planning#129.