Monkeypatch protocol.loads ala dask/distributed#8216 #1247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In versions of distributed after dask/distributed#8067 but before dask/distributed#8216, we must patch protocol.loads to include the same decompression fix.
pentschev
approved these changes
Sep 27, 2023
There was a problem hiding this comment.
Thanks @wence- , LGTM. DGX tests are also passing:
$ pytest -vs dask_cuda/tests/test_dgx.py -k infiniband_nvlink
========================================================================= test session starts =========================================================================
platform linux -- Python 3.9.18, pytest-7.4.2, pluggy-1.3.0
cachedir: .pytest_cache
rootdir: /datasets/pentschev/src/dask-cuda
configfile: pyproject.toml
plugins: asyncio-0.21.1, cov-4.1.0, repeat-0.9.1, rerunfailures-12.0, timeout-2.1.0
asyncio: mode=strict
collected 8 items / 3 deselected / 5 selected
dask_cuda/tests/test_dgx.py::test_ucx_infiniband_nvlink[params0] PASSED
dask_cuda/tests/test_dgx.py::test_ucx_infiniband_nvlink[params1] PASSED
dask_cuda/tests/test_dgx.py::test_ucx_infiniband_nvlink[params2] PASSED
dask_cuda/tests/test_dgx.py::test_ucx_infiniband_nvlink[params3] PASSED
dask_cuda/tests/test_dgx.py::test_ucx_infiniband_nvlink[params4] PASSED
================================================================== 5 passed, 3 deselected in 54.21s ===================================================================I'll trigger a merge right away so we can get projects testing and we can revert changes should this have any unintended consequences. I'll keep an eye on tomorrow's UCX-Py Nightly CI to in case it fails for some reason too.
|
/merge |
pentschev
added a commit
to pentschev/dask-cuda
that referenced
this pull request
Oct 4, 2023
This change was introduced in rapidsai#1247 to include the fix from dask/distributed#8216 for the Dask-CUDA 23.10 which pinned to Distributed 2023.9.2. Starting from Distributed 2023.9.3, the fix is merged in Distributed and this isn't required anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In versions of distributed after dask/distributed#8067 but before dask/distributed#8216, we must patch protocol.loads to include the same decompression fix.