Unpin dask and distributed for 23.12 development
#1264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dask/distributed#8195 has renamed `CustomFile` to `AnyKeyFile`, the import requires updating.
This change was introduced in rapidsai#1247 to include the fix from dask/distributed#8216 for the Dask-CUDA 23.10 which pinned to Distributed 2023.9.2. Starting from Distributed 2023.9.3, the fix is merged in Distributed and this isn't required anymore.
…ributed-breaking-changes
galipremsagar
added
improvement
|
@galipremsagar I pushed the changes from #1256 into your branch, hope you don't mind. |
Absolutely fine by me. Thanks @pentschev ! |
jakirkham
approved these changes
Oct 25, 2023
pentschev
approved these changes
Oct 26, 2023
raydouglass
approved these changes
Oct 26, 2023
|
@pentschev I think we have legit pytest failures this time, do we need to modify them? |
|
I'm looking at them now, will post here shortly. |
|
I'm xfailing the tests for now and filed #1265 to investigate that. |
|
Thanks @pentschev ! |
galipremsagar
added
the
5 - Ready to Merge
|
/merge |
|
We've got some test failures due to AWS segfaults as we're still on PyArrow 12, rerunning those. |
|
This is being really hard here, [792bd23cf9a0:6818 :0:7196] Caught signal 11 (Segmentation fault: address not mapped to object at address 0x10)
==== backtrace (tid: 7196) ====
0 /opt/conda/envs/test/lib/python3.10/site-packages/ucp/_libs/../../../../libucs.so.0(ucs_handle_error+0x2fd) [0x7f1dff619fed]
1 /opt/conda/envs/test/lib/python3.10/site-packages/ucp/_libs/../../../../libucs.so.0(+0x2a1e1) [0x7f1dff61a1e1]
2 /opt/conda/envs/test/lib/python3.10/site-packages/ucp/_libs/../../../../libucs.so.0(+0x2a3aa) [0x7f1dff61a3aa]
3 /usr/lib/x86_64-linux-gnu/libc.so.6(+0x42520) [0x7f2080993520]
4 /opt/conda/envs/test/lib/python3.10/site-packages/pyarrow/../../.././libaws-cpp-sdk-core.so(+0x824cc) [0x7f1e60d644cc]
5 /opt/conda/envs/test/lib/python3.10/site-packages/pyarrow/../../../././libaws-c-io.so.1.0.0(+0x1c843) [0x7f1e60326843]
6 /opt/conda/envs/test/lib/python3.10/site-packages/pyarrow/../../../././libaws-c-io.so.1.0.0(+0x167e6) [0x7f1e603207e6]
7 /opt/conda/envs/test/lib/python3.10/site-packages/pyarrow/../../../././libaws-c-io.so.1.0.0(+0x16839) [0x7f1e60320839]
8 /opt/conda/envs/test/lib/python3.10/site-packages/pyarrow/../../../././libaws-c-common.so.1(+0x26419) [0x7f1e604b3419]
9 /usr/lib/x86_64-linux-gnu/libc.so.6(+0x94ac3) [0x7f20809e5ac3]
10 /usr/lib/x86_64-linux-gnu/libc.so.6(clone+0x44) [0x7f2080a76bf4]
================================= |
pentschev
added a commit
to pentschev/dask-cuda
that referenced
this pull request
Oct 27, 2023
Some tests were previously disabled in rapidsai#1264 to prevent segfaults that should now be resolved after upgrading to Arrow 13.
rapids-bot bot
pushed a commit
that referenced
this pull request
Oct 27, 2023
Some tests were previously disabled in #1264 to prevent segfaults that should now be resolved after upgrading to Arrow 13. Authors: - Peter Andreas Entschev (https://github.com/pentschev) Approvers: - GALI PREM SAGAR (https://github.com/galipremsagar) URL: #1266
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR relaxes
daskanddistributedversions pinning for23.12development.xref: rapidsai/cudf#14320