-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Azure Infiniband Updated Ubuntu Versions #462
Conversation
Co-authored-by: Jacob Tomlinson <[email protected]>
Co-authored-by: Jacob Tomlinson <[email protected]>
Co-authored-by: Jacob Tomlinson <[email protected]>
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Left some small suggestions, but none of them need to block merging.
I don't know why dpatch
was in this example, but if you ran the entire example end-to-end and it succeeded without it, I'm confident it can be removed.
Co-authored-by: James Lamb <[email protected]>
Co-authored-by: James Lamb <[email protected]>
thanks @jameslamb ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great thanks @melodywang060 (and @jameslamb for review)
Problem 1
On the guide it says to select the
Ubuntu Server 20.04
image, but this image is outdated and not available anymore.Quick Fix
Replace with the newest version
Ubuntu Server 24.04
Problem 2
This command
wget https://developer.download.nvidia.com/compute/cuda/repos/$distribution/x86_64/cuda-keyring_1.0-1_all.deb
yields a 404 NOT FOUND error becausecuda-keyring_1.0-1_all.deb
does not exist anymoreQuick Fix
Replace with the latest version,
cuda-keyring_1.1-1_all.deb
Problem 3
In this command,
sudo apt-get install -y automake dh-make git libcap2 libnuma-dev libtool make pkg-config udev curl librdmacm-dev rdma-core \ libgfortran5 bison chrpath flex graphviz gfortran tk dpatch quilt swig tcl ibverbs-utils
the
dpatch
package does not exist anymore - is there a replacement or can we just delete this requirement?Quick Fix
Problem 4
Users who are not too aware of running
conda init
might exit out of the shell first.Quick Fix
Adding a line that demonstrates how to enable conda and restart shell will clarify potential confusions users may have.