Update Azure ML XGBoost instructions to Ubuntu 24.04

[melodywang060]

Addresses #464

[review-notebook-app]

Check out this pull request on 

See visual diffs & provide feedback on Jupyter Notebooks.

---

Powered by ReviewNB

[jameslamb]

Thanks for this! Left some small suggestions. Please do check how this renders at https://github.com/rapidsai/deployment/blob/xgboost-azure/source/cloud/azure/aks.md after pushing, in case there are other missing/extra backticks that were missed.

It's cool that this worked on Ubuntu 24.04, given that we don't actively test any RAPIDS libraries on that operating system yet! (rapidsai/build-planning#74)

[jameslamb]

Also, since the PR title will become the commit message when this is squash-merged (https://github.com/rapidsai/deployment/commits/main/), could you give it a more descriptive title? Something like "Update Azure ML XGBoost instructions to Ubuntu 24.04".

[melodywang060]

Thanks for the review & suggestions @jameslamb ! I often forget to check the linting after making PRs - need to get into that habit 💪

[jameslamb]

I strongly suspect that checking package-lock.json and package.json in here were unintentional (probably the result of running npm install prettier or similar). If I'm right about that, could you please remove them and add new rules to .gitignore to prevent that happening again?

[melodywang060]

thanks for pointing that out @jameslamb! Just removed and added to .gitignore

[jameslamb]

I've left a few more formatting changes for your consideration. Publishing those recommendations now, will look at the ReviewNB diff of the notebook next.

[jameslamb]

This doesn't look right to me... were these removed by accident? Please check how this renders in the GitHub UI on your branch (https://github.com/rapidsai/deployment/blob/xgboost-azure/source/guides/azure/infiniband.md)... I can see there that removing this causes some text that's not intended to be code-formatting being represented in a code block.

In case you're new to working in markdown, I've found these really helpful:

• https://docs.github.com/en/get-started/writing-on-github/getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax
• https://yihui.org/en/2021/06/markdown-breath/

[melodywang060]

thanks for the links!

[jameslamb]

I'm struggling to understand the diff for source/examples/xgboost-gpu-hpo-mnmg-parallel-k8s/notebook.ipynb. git seems to think the entire file has been overwritten with new content, but it doesn't look that way to me. Given that all the "new" logs still have dates from Spring 2024, I suspect that you didn't re-run this notebook, and that maybe what's happening is something whitespace related (like maybe you opened this on a Windows machine and all the line endings were replaced).

Could you explain what you intended to change about this notebook? If the answer is "nothing", then you could just revert these changes like this:

git checkout main

git pull origin main

git checkout xgboost-azure

git checkout main -- ./source/examples/xgboost-gpu-hpo-mnmg-parallel-k8s/notebook.ipynb

git add ./source

git commit -m "revert changes to xgboost-gpu-hpo-mnmg-parallel-k8s notebook"

git merge main

git push origin xgboost-azure

(those instructions assume you have rapidsai/deployment aliased as origin, which I'm guessing you do since this branch is on that repo and not coming from a fork).

Reply via ReviewNB

[melodywang060]

This PR initially was intended to change the hardcoded configurations to "FILL-THIS-IN", but I think after trying to fix linting issues and running prettier, ruff, and black locally multiple times, somehow the file formatting got messed up. Do you think I should re-implement these changes and make a new PR instead?

[jameslamb]

I don't see any FILL THIS IN or similar in the diff for xgboost-gpu-hpo-mnmg-parallel-k8s/notebook.ipynb ... are you sure you made updates like that there?

I recommend re-doing those changes in the way I described in my comment above. And then don't run any of those linters by invoking the tools directly... only use pre-commit to run them, like this from the root of the repo:

pre-commit run --all-files

[melodywang060]

Got it, I'll work on that - thank you for the suggestions, very helpful 👍🏼

[jameslamb]

Sorry, there was a typo in what I typed out. Should have been

git checkout main -- ./source/examples/xgboost-gpu-hpo-mnmg-parallel-k8s/notebook.ipynb

Which is "get the state of that file from the main branch".

I'll send you some other commands to fix the conflicts here privately.

[bdice]

A couple formatting fixes are needed. I will go ahead and apply them. edit: I lack permissions.

I'm not sure if GitHub can even render these suggestions correctly. The four-backtick blocks need to use three backticks instead.

[jacobtomlinson]

Thanks @bdice. I tweaked your suggestion block to use four backticks around the three backtick suggestion which got things working correctly.