Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CUDA 12.8 to CUDA feature #453

Merged
merged 2 commits into from
Jan 28, 2025
Merged

Add CUDA 12.8 to CUDA feature #453

merged 2 commits into from
Jan 28, 2025

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Jan 27, 2025 •
edited
Loading

Adds 12.8 and 12.6 to the CUDA feature.

xref: rapidsai/build-planning#139

@bdice bdice requested a review from a team as a code owner January 27, 2025 22:42
@bdice bdice requested review from msarahan and removed request for a team January 27, 2025 22:42
trxcllnt
trxcllnt requested changes Jan 27, 2025
View reviewed changes
Copy link
Collaborator

@trxcllnt trxcllnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we update the default from 12.5 to 12.8? If so, will probably need to update tests.

@bdice
Copy link
Contributor Author

bdice commented Jan 27, 2025

I was going to update the default to 12.8 later -- we want to roll out 12.8 support across RAPIDS first, I think.

@jakirkham
Copy link
Member

Agreed. To help us remember, filed a tracking issue: #455

@bdice bdice requested a review from trxcllnt January 28, 2025 17:40
@bdice bdice merged commit 02184c5 into rapidsai:branch-25.02 Jan 28, 2025
163 of 165 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trxcllnt trxcllnt trxcllnt approved these changes

@msarahan msarahan Awaiting requested review from msarahan msarahan is a code owner automatically assigned from rapidsai/packaging-codeowners

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bdice @jakirkham @trxcllnt