Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove cugraph-ops references #567

Merged
merged 1 commit into from
Jan 18, 2025
Merged

Conversation

jameslamb
Copy link
Member

@jameslamb jameslamb commented Jan 13, 2025

Contributes to https://github.com/rapidsai/build-infra/issues/155 (private issue)

Complements rapidsai/rapids.ai#426 and #566

Proposes removing references to cugraph-ops from release 25.02 onwards. RAPIDS is dropping cugraph-ops in its 25.02 release (ref: #566)

Notes for Reviewers

This should not be merged until the following are complete:

Copy link

vercel bot commented Jan 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Jan 13, 2025 3:26pm

Copy link

netlify bot commented Jan 13, 2025

Deploy Preview for docs-rapids-ai ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 7ca9f29
🔍 Latest deploy log https://app.netlify.com/sites/docs-rapids-ai/deploys/67853069abcab1000822d6e2
😎 Deploy Preview https://deploy-preview-567--docs-rapids-ai.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jameslamb jameslamb changed the title WIP: remove cugraph-ops references remove cugraph-ops references Jan 17, 2025
@jameslamb jameslamb marked this pull request as ready for review January 17, 2025 19:56
@jameslamb jameslamb requested a review from a team as a code owner January 17, 2025 19:56
@@ -38,7 +38,7 @@ apis:
cugraph:
name: cuGraph
path: cugraph
desc: 'cuGraph is a GPU accelerated graph analytics library, with functionality like NetworkX, which is seamlessly integrated into the RAPIDS data science platform. cuGraph supports GNNs with PyG, DGL packages and cugraph-ops (for low level optimized operations) as well as cugraph-service for analytics on a remote graph and WHOLEGRAPH for memory management.'
desc: 'cuGraph is a GPU accelerated graph analytics library, with functionality like NetworkX, which is seamlessly integrated into the RAPIDS data science platform. cuGraph supports GNNs with PyG, DGL packages, cugraph-service for analytics on a remote graph, and WHOLEGRAPH for memory management.'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably rewrite this and add a separate block of links for cugraph-gnn. It's a separate repo now, so I would like to have a GitHub link and changelog link for it that is separate from cugraph.

@BradReesWork @rlratzel @alexbarghi-nv What are your thoughts?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a similar proposal for nx-cugraph: #538

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the structure of having one top-level /cugraph/ path pointing to all the other projects is intentional as part of the docs reorg @acostadon has been doing.

Right now, https://github.com/rapidsai/cugraph-docs is uploaded docs for all of the cuGraph projects, at paths like this:

s3://rapidsai-docs/cugraph/html/25.02/_sources/api_docs/api/cugraph-pyg/cugraph_pyg.loader.neighbor_loader.NeighborLoader.rst.txt

(docs link)

Notice the leading cugraph/ .... to my understanding, that's what groups all objects with a prefix like s3://rapidsa-docs/cugraph under a page like this: https://docs.rapids.ai/api/cugraph/nightly/

Screenshot 2025-01-17 at 4 14 09 PM

Or, more specifically, that plus this script relying on that convention:

SRC="s3://${DOCS_BUCKET}/${PROJECT}/html/${VERSION_NUMBER}/"
DST="$(yq -n 'env(GENERATED_DIRS)|.libs')/${PROJECT}/${VERSION_NUMBER}/"
aws_cp "${SRC}" "${DST}"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay. We can merge this as-is and revisit the docs links another time.

@bdice bdice merged commit 9a68276 into rapidsai:main Jan 18, 2025
6 checks passed
@jameslamb jameslamb deleted the remove-cugraph-ops branch January 22, 2025 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants