-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove cugraph-ops references #567
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for docs-rapids-ai ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
@@ -38,7 +38,7 @@ apis: | |||
cugraph: | |||
name: cuGraph | |||
path: cugraph | |||
desc: 'cuGraph is a GPU accelerated graph analytics library, with functionality like NetworkX, which is seamlessly integrated into the RAPIDS data science platform. cuGraph supports GNNs with PyG, DGL packages and cugraph-ops (for low level optimized operations) as well as cugraph-service for analytics on a remote graph and WHOLEGRAPH for memory management.' | |||
desc: 'cuGraph is a GPU accelerated graph analytics library, with functionality like NetworkX, which is seamlessly integrated into the RAPIDS data science platform. cuGraph supports GNNs with PyG, DGL packages, cugraph-service for analytics on a remote graph, and WHOLEGRAPH for memory management.' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably rewrite this and add a separate block of links for cugraph-gnn
. It's a separate repo now, so I would like to have a GitHub link and changelog link for it that is separate from cugraph
.
@BradReesWork @rlratzel @alexbarghi-nv What are your thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have a similar proposal for nx-cugraph: #538
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the structure of having one top-level /cugraph/
path pointing to all the other projects is intentional as part of the docs reorg @acostadon has been doing.
Right now, https://github.com/rapidsai/cugraph-docs is uploaded docs for all of the cuGraph projects, at paths like this:
s3://rapidsai-docs/cugraph/html/25.02/_sources/api_docs/api/cugraph-pyg/cugraph_pyg.loader.neighbor_loader.NeighborLoader.rst.txt
Notice the leading cugraph/
.... to my understanding, that's what groups all objects with a prefix like s3://rapidsa-docs/cugraph
under a page like this: https://docs.rapids.ai/api/cugraph/nightly/
Or, more specifically, that plus this script relying on that convention:
Lines 95 to 98 in 978038f
SRC="s3://${DOCS_BUCKET}/${PROJECT}/html/${VERSION_NUMBER}/" | |
DST="$(yq -n 'env(GENERATED_DIRS)|.libs')/${PROJECT}/${VERSION_NUMBER}/" | |
aws_cp "${SRC}" "${DST}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay. We can merge this as-is and revisit the docs links another time.
Contributes to https://github.com/rapidsai/build-infra/issues/155 (private issue)
Complements rapidsai/rapids.ai#426 and #566
Proposes removing references to
cugraph-ops
from release 25.02 onwards. RAPIDS is droppingcugraph-ops
in its 25.02 release (ref: #566)Notes for Reviewers
This should not be merged until the following are complete: