Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add mkdir -p for telemetry-artifacts #148

Merged
merged 3 commits into from
Feb 26, 2025

Conversation

msarahan
Copy link
Contributor

The build scripts encountered issues when carrying out build workflows (as opposed to PR workflows) because build workflows do not yet have the telemetry boilerplate. One element of this boilerplate is creation of a folder that build scripts can place content into. That content will be available when telemetry is being parsed.

This PR adds an abstraction layer of sorts, so that we can make changes to telemetry setup without requiring changes to every repo. This script should be run (or sourced?) by the ci/build_XYZ.sh scripts in each project.

@msarahan msarahan marked this pull request as ready for review February 26, 2025 00:30
@msarahan msarahan requested a review from a team as a code owner February 26, 2025 00:30
@msarahan msarahan requested review from KyleFromNVIDIA and removed request for a team February 26, 2025 00:30
@msarahan msarahan merged commit bdba75d into rapidsai:main Feb 26, 2025
1 check passed
@msarahan msarahan deleted the mkdir-p-for-telemetry branch February 26, 2025 00:48
rapids-bot bot pushed a commit to rapidsai/rmm that referenced this pull request Feb 26, 2025
Please refer to rapidsai/gha-tools#148 for explanation here.

Authors:
  - Mike Sarahan (https://github.com/msarahan)

Approvers:
  - James Lamb (https://github.com/jameslamb)

URL: #1839
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants