Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't test unnecessary features of rapids-logger #753

Merged
merged 2 commits into from
Feb 27, 2025
Merged

Don't test unnecessary features of rapids-logger #753

merged 2 commits into from
Feb 27, 2025

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Feb 27, 2025

@vyasr vyasr self-assigned this Feb 27, 2025
@vyasr vyasr requested a review from a team as a code owner February 27, 2025 19:39
@vyasr vyasr requested a review from msarahan February 27, 2025 19:39
@jameslamb jameslamb removed the request for review from msarahan February 27, 2025 19:40
@jameslamb
Copy link
Member

cross-linking why I agree and approved: #752 (review)

@bdice bdice added non-breaking bug Something isn't working labels Feb 27, 2025
@bdice
Copy link
Contributor

bdice commented Feb 27, 2025

/merge

@rapids-bot rapids-bot bot merged commit b7af44c into branch-25.04 Feb 27, 2025
32 checks passed
@jakirkham
Copy link
Member

Thanks all! 🙏

Happy with relaxing tests if that is our preference

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@jameslamb jameslamb jameslamb approved these changes

Assignees

@vyasr vyasr

Labels
bug Something isn't working non-breaking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rapids-logger missing date string?
4 participants
@vyasr @jameslamb @bdice @jakirkham