Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force downloading spdlog by default to avoid using system packages and fmt linkage #1740

Draft
wants to merge 6 commits into
base: branch-25.02
Choose a base branch
from
Draft

Force downloading spdlog by default to avoid using system packages and fmt linkage #1740

wants to merge 6 commits into from

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Nov 27, 2024

Description

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@vyasr vyasr added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Nov 27, 2024
@vyasr vyasr self-assigned this Nov 27, 2024
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Nov 27, 2024

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@github-actions github-actions bot added the CMake label Nov 27, 2024
@vyasr
Copy link
Contributor Author

vyasr commented Nov 27, 2024

/ok to test

@vyasr
Copy link
Contributor Author

vyasr commented Nov 27, 2024

/ok to test

@github-actions github-actions bot added the conda label Nov 28, 2024
@vyasr
Copy link
Contributor Author

vyasr commented Nov 28, 2024

/ok to test

@vyasr vyasr mentioned this pull request Dec 6, 2024
Merged
3 tasks
@bdice
Copy link
Contributor

bdice commented Dec 17, 2024

@vyasr Is this still needed?

@vyasr
Copy link
Contributor Author

vyasr commented Dec 19, 2024

Yes. I'll get back to this after all of RAPIDS is migrated onto rapids-logger.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@vyasr vyasr

Labels
CMake conda improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
RMM Project Board
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vyasr @bdice