-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add argument for path to pico_configs file #27
Conversation
#26 is related. Maybe just that PR is enough to fix this. There's not much progress there, so I am leaving this PR as it is for now. |
|
Something has gone a bit pear shaped in that commit. Might be worth trying a "git pull --rebase" from the upstream master, then doing a push of the resulting tree to your codebase. That SHOULD update the PR to only have your changes in it. Or not... |
More specifically, I think the following sequence of commands should sort you out: git fetch origin
git checkout config-file-arg
git rebase origin/master
git push -f fork config-file-arg |
4df5bf2
to
790cf26
Compare
790cf26
to
2e90b20
Compare
This does the job. Thanks for the help! |
10747f5
to
3abd3c8
Compare
This LGTM now @lurch? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Thanks all! |
The path to
pico_configs.tsv
is hard-coded in the generator script. It complains when I use the generator in other scripts and even when I symlinked the script to myPATH
for convenience. An option to specify where to find it will remove all this hassle. This PR aims to do just that.