Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include pico_tone library #1569

Closed
wants to merge 3 commits into from

Conversation

jcarranz97
Copy link

@jcarranz97 jcarranz97 commented Dec 3, 2023

Fixes #1568

This PR includes tone functions to generate tones using PWM.

The tone function is similar to tone() from Arduino. I have also included a no_tone function to silence buzzer if needed.

I have a PR open in pico-examples repository which includes an example usage for this library.

Inspiration and References:

@lurch
Copy link
Contributor

lurch commented Dec 3, 2023

This might be better suited to https://github.com/raspberrypi/pico-extras than it is to pico-sdk ?

@jcarranz97
Copy link
Author

That is probably the best approach ...

Is the normal process first propose new libraries and examples against pico-extrasand pico-playground?
If that is case, I can go ahead an move my PRs to those repos 👀

@lurch
Copy link
Contributor

lurch commented Dec 4, 2023

I believe the way it normally works is that if your example works out-of-the-box with the develop version of pico-sdk then you'd just submit it against pico-examples; but if your example relies on pico-extras then you'd submit it against pico-playground.

So in answer to your question: yes 😃

@jcarranz97
Copy link
Author

Thanks for the advice, I have just opened a PR against pico-extras to include this library there 💪
raspberrypi/pico-extras#70

@kilograham kilograham added this to the 1.6.0 milestone Dec 15, 2023
@peterharperuk peterharperuk self-assigned this Jan 12, 2024
@kilograham kilograham modified the milestones: 1.6.0, 1.7.0 May 19, 2024
@kilograham kilograham added the enhancement New feature or request label May 19, 2024
@peterharperuk
Copy link
Contributor

Not an sdk issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants