pico_flash stops including certain unneeded headers #1699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah, we have |
|
@kilograham kitchen_sink_test is already building without my change, however, the test I'm adding is not. I'm still happy to remove it, but I think kitchen_sink_test is hiding the bug by pulling in hardware_exception as a separate dependency. Just wanted to reconfirm that you want it removed even though we have no coverage of the underlying issue already. |
|
ah good point, but yeah, i think remove it... we should add a separate (hopefully automated) check of each library |
jaguilar
changed the title
|
Updated the state to just remove those three includes. Thank you for taking the time to review. |
kilograham
approved these changes
May 20, 2024
peterharperuk
added a commit
to peterharperuk/pico-sdk
that referenced
this pull request
Jun 10, 2024
hardware/flash.h has been removed from pico/flash.h in the fix for raspberrypi#1699. This breaks btstack compilation. Let's fix it.
kilograham
pushed a commit
that referenced
this pull request
Jun 10, 2024
hardware/flash.h has been removed from pico/flash.h in the fix for #1699. This breaks btstack compilation. Let's fix it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1698