Update btstack v1.6.1 #1736
Update btstack v1.6.1 #1736
Conversation
|
fyi @mringwal This seems to work for develop as well |
| @@ -3,6 +3,10 @@ if (DEFINED ENV{PICO_BTSTACK_PATH} AND (NOT PICO_BTSTACK_PATH)) | |||
| message("Using PICO_BTSTACK_PATH from environment ('${PICO_BTSTACK_PATH}')") | |||
| endif () | |||
|
|
|||
| if (NOT PICO_BTSTACK_VERSION) | |||
There was a problem hiding this comment.
How is the user supposed to use this; I assume they are supposed to set it if they are using a different version of btstack? It needs have PICO_CMAKE_CONFIG in that case, however it feels a bit odd that we expect them to set it, if it doesn't actual cause anything to happen e.g. choosing a version (if we just care about what version we have, can we determine it?)
There was a problem hiding this comment.
Yes, they'd define this if they want to use this cmake file to build an older version of btstack than the version in the sdk.
it feels a bit odd that we expect them to set it, if it doesn't actual cause anything to happen
Sorry, I don't follow this comment. It would cause the build to not fail.
There was a problem hiding this comment.
can we determine it?
Yes, maybe that's better. We can infer it's an older version by seeing if the file is there. I'll try that out.
There was a problem hiding this comment.
Ideally, all information about BTstack could/should be contained in the BTstack repo and Pico SDK would only refer to it. I'm not too familiar with your build system, but you may make some suggestions on how this could look like. E.g. we could stash Pico related files under port/pico-sdk, or just have CMakeLists.txt files that contains source files and include paths.
There was a problem hiding this comment.
I've pushed a version that just checks if the file exists.
Ideally, all information about BTstack could/should be contained in the BTstack repo
The ideal is to just include a file in the btstack repo. But arguably, it's too late now?
There was a problem hiding this comment.
It's never too late :) but the support for the initial version probably must stay. If this single file would exist, I could create a branch of v1.6.1 plus that file and you could already use it.
We've started using CMake, but not consistently. A colleague did a rewrite of the build files for the desktop targets, but I'm somehow not happy with it without a clear argument against it.
peterharperuk
force-pushed
the
update_btstack_v1.6.1
branch
from
6c98262 to
a2dd851
Compare
No description provided.