Add CYW43_WL_GPIO_SMPS_PIN for pico_w and pico2_w #2410
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
where is WL_GPIO_SMPS_PIN used - i don't see it referenced or PICO_CONFIGed? |
|
I'm going to re-push this to try and understand the github build failures. Please ignore. |
peterharperuk
force-pushed
the
add_smps_pin_dev
branch
2 times, most recently
from
4a6f323 to
c9a6047
Compare
peterharperuk
force-pushed
the
add_smps_pin_dev
branch
from
c9a6047 to
f7697a6
Compare
It's not used. I recently tried setting it to see if it was having any effect on Wireless stability. I realised at that point that I never had a define for it. We have PICO_DEFAULT_SMPS_PIN for non-wifi devices. Do you want me to add PICO_CONFIG for all the defines in the board file? |
|
no it is good; i misunderstood what it was about - might be worth adding it to an example |
kilograham
approved these changes
Apr 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2361