Fix spaces in parent folder name #18
Conversation
This commit fixes Issue raspberrypi#17
|
Not needed on Raspberry Pi OS, but might be worthwhile merging in any case? |
|
Why not needed on PiOS? If there is space in the installation folder name, I think pico-setup would fail? |
| @@ -10,7 +10,7 @@ else | |||
| fi | |||
|
|
|||
| # Number of cores when running make | |||
| JNUM=4 | |||
| JNUM=$(cat /proc/cpuinfo | grep processor | wc -l) | |||
There was a problem hiding this comment.
Please make this change in a separate PR, as it's unrelated the the spaces-in-path issue.
There was a problem hiding this comment.
Ahh.. Apologies I missed that. Will do.
There was a problem hiding this comment.
It looks like you removed this, but then added it back again??
You might find things easier to manage if you do them on separate branches, rather than doing everything on protik09:master 🙂
There was a problem hiding this comment.
ping @protik09 again. Can you please update this PR to remove this change?
Doh! Fair point. I was totally in the mindset of "well it works on my machine!" Blame it on Monday and not enough coffee? 🤦♂️ |
| @@ -90,12 +90,12 @@ cmake ../ -DCMAKE_BUILD_TYPE=Debug | |||
| for e in blink hello_world | |||
| do | |||
| echo "Building $e" | |||
| cd $e | |||
| cd "$e" | |||
There was a problem hiding this comment.
Technically not needed here, as neither blink nor hello_world contain spaces 😉 (but I guess it doesn't hurt)
There was a problem hiding this comment.
I'd be inclined to keep the quotes everywhere they may be needed, to make it future proof/consistent
There was a problem hiding this comment.
Agreed, that's why I said "(but I guess it doesn't hurt)"
Temporary fix to remove unrelated info from pull request for Issue raspberrypi#17
This gives max compile speed on any Raspberry Pi
|
Superseded by #20. But note that one of |
This commit fixes Issue #17