Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add shape filter to scenes in api and hook up frontend #3142

Merged
merged 1 commit into from
Apr 12, 2018
Merged

Add shape filter to scenes in api and hook up frontend #3142

merged 1 commit into from
Apr 12, 2018

Conversation

aaronxsu
Copy link
Member

@aaronxsu aaronxsu commented Apr 9, 2018 •
edited
Loading

Overview

This PR:

  • Adds backend support to enable scene filter based on an existing shape in the shapes table for Raster Foundry repo
  • Updates frontend shapes filter to enable it for Raster Foundry data repo
  • Fixes a minor frontend issue to let shape filter persist when other filters are also applied

Checklist

  • Styleguide updated, if necessary
  • Swagger specification updated
  • Symlinks from new migrations present or corrected for any new migrations
  • PR has a name that won't get you publicly shamed for vagueness

Notes

Spec update is in raster-foundry/raster-foundry-api-spec#7

Testing Instructions

  • Go to a project and browse scenes
  • See if the shape filter is in the filter pane under raster foundry repo
  • If yes, apply shape filter (make sure you have shapes or create a new one) along with other filters and see if it behaves as you would expect
  • Switch to other data repo, e.g. Planet Labs, to see if shape filter and other filters work as you would expect

Closes #2893

@aaronxsu aaronxsu requested a review from Lknechtli April 9, 2018 23:15
@aaronxsu
Add backend to support shape filters on scenes.
435e911 
Update frontend to enable shape filter,
Fix frontend bug in rf scene shape filter
... where the shape filter does not persist if other filters are applied.
@aaronxsu aaronxsu force-pushed the feature/asu/add-shape-filter-to-scenes-in-api branch from 2e231c9 to 435e911 Compare April 9, 2018 23:17
@aaronxsu aaronxsu mentioned this pull request Apr 9, 2018
Merged
@alkamin alkamin requested review from alkamin and removed request for Lknechtli April 11, 2018 21:01
@alkamin alkamin assigned alkamin and unassigned Lknechtli Apr 11, 2018
alkamin
alkamin approved these changes Apr 12, 2018
View reviewed changes
Copy link
Contributor

@alkamin alkamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works well. Good to go!

I tested multi-polygon support but ended up running into this issue: #3146

I think once this issue is fixed that this PR would also handle the MultiPolygon case just fine.

@aaronxsu aaronxsu merged commit e1e1fb3 into develop Apr 12, 2018
@notthatbreezy notthatbreezy deleted the feature/asu/add-shape-filter-to-scenes-in-api branch June 25, 2018 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alkamin alkamin alkamin approved these changes

Assignees

@alkamin alkamin

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aaronxsu @alkamin @Lknechtli