This repository has been archived by the owner on Aug 6, 2024. It is now read-only.
chore: revert changes to handle new and old QR formats + sentry logging [SGW-3617] [SGW-4562] #792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalsontws
force-pushed
the
revert-789-revert-777-feat/scan-login-QR-to-navigate-to-endpoint-
branch
from
3620b34
to
d92ba04
Compare
dalsontws
changed the title
Application
Storybook
|
dalsontws
commented
Jun 6, 2024
Comment on lines
+55
to
+62
| // We had some issues with deep-linking endpoints on web app, | ||
| // and had to use ASCII encoding of special characters as a solution | ||
| // However the mobile app doesn't seem to recognise this well hence we | ||
| // need to replace them if present | ||
| const cleanedEndpoint = parsedCode.endpoint.replace( | ||
| "https%3A%2F%2F", | ||
| "https://" | ||
| ); |
There was a problem hiding this comment.
needed to ensure ASCII encoded endpoints (required for web app) works
dalsontws
changed the title
legendac
approved these changes
Jun 6, 2024
dalsontws
deleted the
revert-789-revert-777-feat/scan-login-QR-to-navigate-to-endpoint-
branch
dalsontws
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notion link
video_2024-06-06_16-14-18.mp4