Skip to content
This repository has been archived by the owner on Aug 6, 2024. It is now read-only.

chore: sentry info logs - to track mobile app usage [SGW-4520] #794

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

dalsontws
Copy link
Contributor

@dalsontws dalsontws commented Jun 6, 2024

Notion link

This PR adds...

  • info log of check quota and get otp
  • I've kept this PR as small as possible (~600 lines) by splitting it into PRs with manageable chunks of code
  • I've requested reviews from 1-2 reviewers
  • I've added accessibility IDs to my components
  • I've added/updated unit/integration tests
  • I've added/updated e2e tests for at least the happy flow
  • I've added Chinese translations for i18n setup
  • I've added documentation in README/Notion

@dalsontws dalsontws self-assigned this Jun 6, 2024
Copy link

@supplyally-bot
Copy link

Application

Expo QR
OR Enter this link into your dev client: exp+rationally://expo-development-client/?url=https://u.expo.dev/cf511b6b-f66b-45b5-b856-2339182f8052?channel-name=pr794

Storybook

Expo QR
OR Enter this link into your dev client: exp+rationally://expo-development-client/?url=https://u.expo.dev/cf511b6b-f66b-45b5-b856-2339182f8052?channel-name=storybook-pr794

@dalsontws dalsontws force-pushed the chore/sentry-info-check-quota branch from 6725da6 to a2e1578 Compare June 7, 2024 02:51
Copy link
Contributor

@ilhaoni ilhaoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dalsontws dalsontws merged commit 65570c5 into master Jun 10, 2024
8 checks passed
@dalsontws dalsontws deleted the chore/sentry-info-check-quota branch June 10, 2024 11:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants