-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes and improvements #36
Open
panosru
wants to merge
15
commits into
ravelsoft:master
Choose a base branch
from
panosru:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added outputUndefinedVariable and outputUndefinedVariableWithBrackets flags
This reverts commit f2b3848.
Added support for let for compatibility purposes. (Deprecated)
Update tests
Added npm-shrinkwrap.json in order to better control the versions of dependencies (for instance pegjs 0.7.0 breaks tests so we make sure that we install 0.6.2)
Tests:
|
Added options support but also left previous methods for legacy compatibility reasons.
Options method addedNow instead of having multiple methods when initializing jinjs engine you can have only For instance instead of this: require("jinjs");
jinjs.registerExtension(".tpl", function (txt) {
return my_transformation_module.transform_text(txt);
});
jinjs.registerExtension(".jin");
jinjs.registerExtension(".html", function (txt) { return txt; });
jinjs.outputUndefinedVariable(true, true); you can have this: require("jinjs").options({
extensions : [
{ ext : '.tpl', filter : function (txt) {
return my_transformation_module.transform_text(txt);
}},
{ ext : '.jin' },
{ ext : '.html', filter : function (txt) { return txt; }}
],
outputUndefinedVariable : true,
outputUndefinedVariableWithBrackets : true
}); |
Just a +1 to this. I'd really like to see these changes merged back into master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
float
filter so it return 0.0 instead of NaNreverse
filter supports number, string and arrayoutputUndefinedVariable
flagoutputUndefinedVariableWithBrackets
flagnpm-shrinkwrap.json
for better dependency control