Indicate absence with a boolean return, instead of nil pointers #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zenhack
force-pushed
the
ok-flag
branch
3 times, most recently
from
5d7d9f6 to
63ea5a3
Compare
|
Rebased on top of v2 and fixed some linter errors. Should be good to go now. |
Codecov Report
@@ Coverage Diff @@
## v2 #25 +/- ##
=====================================
Coverage ? 95.00%
=====================================
Files ? 5
Lines ? 240
Branches ? 0
=====================================
Hits ? 228
Misses ? 10
Partials ? 2 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Sorry, I didn't mean that I want you to implement it but thanks for the code! I'll first put up an issue for this change to see to make sure that no one has any obligations. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...per discussion.