Add support for ini file. #363
Conversation
Motivation: In CI we have multiple invocations of muffet with mostly the same arguments. This is cumbersome to maintain all the other args. Thus we'd like to have support for a config file to use as default Implementation: Always use `muffet.ini`. I thought it was likely unecessary to support anything different until the need comes for it. Signed-off-by: Charly Molter <[email protected]>
|
Hi. Thank you for the PR! What OS do you use on CI? In your use cases, are scripts (shell scripts or batch files) not sufficient? |
|
It's all github actions: We could make it a bash script but as you can see there's no checkout so we'd end up creating the bash file and then running it. It could work or we could have a config file like I'm adding here. In any case it's your repo if you don't feel you need the added complexity of ini files feel free to close :) PS: another alternative I thought about was EnvVars but this was tricky for repeated args (like |
Sorry, I think I still don't understand how you want to use this feature. 😅 How do you put the |
|
I think we'd probably put a |
|
Let's discuss this first in an issue! #365 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #363 +/- ##
==========================================
+ Coverage 87.50% 87.60% +0.10%
==========================================
Files 30 30
Lines 872 702 -170
==========================================
- Hits 763 615 -148
+ Misses 88 64 -24
- Partials 21 23 +2 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Motivation:
In CI we have multiple invocations of muffet with mostly the same arguments.
This is cumbersome to maintain all the other args.
Thus we'd like to have support for a config file to use as default
Implementation:
Always use
muffet.ini. I thought it was likely unecessary to supportanything different until the need comes for it.
Signed-off-by: Charly Molter [email protected]