-
-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cups #92
Cups #92
Conversation
It isn't the best API at the moment. Could be better.
|
Thanks for contributing this, and sorry I haven't reviewed it until now. I'm going to merge this, however I'll probably modify some of it to match my preferred coding style. |
Of course, I just set the ball rolling :) |
Could you tell me what the Version enum is meant for? I'm not super familiar with CUPS, so I'm not sure what the Version is referring to or means. |
Some Cups versions support different versions of IPP. So the enum helps define which one to use for compatibility with the CUPS server you're communicating with. NB! I'm by no means an expert when it comes to IPP :), I needed some cups functionality. |
1️⃣ Is this something that is wanted/needed? Did you create an issue / discussion about it first?
Should solve #74, #81
2️⃣ Does it contain multiple, unrelated changes? Please separate the PRs out.
Nope.
3️⃣ Does it include tests, if possible? (Not a deal-breaker, just a nice-to-have)
Currently I modified the existing tests, will add more if needed.
4️⃣ Please include a thorough description of the improvement and reasons why it's useful.
Removes the smalot/cups-ipp dependency.
5️⃣ Thanks for contributing! 🙌
Some side notes.