Serializable provider provider #291
Merged
Commits on Sep 7, 2024
-
Make anonymous providers serialisable
Replaced anonymous class with ProviderProvider in ProviderSetProvider. This makes it serialisable.This improves code reuse and readability by consolidating instance retrieval logic into a dedicated class.
-
Remove unnecessary PHPStan ignore comment
Removed a PHPStan ignore comment in the LazyTo.php file to ensure proper type checking by the static analysis tool. This change improves code quality by allowing PHPStan to enforce type checks on the `getInstance` method call.
-
Ignore Ray_Di_* test files in PHPStan config
Added a new pattern to the PHPStan configuration to exclude all test files matching 'tests/di/Ray_Di_*'. This helps to prevent analysis of test artifacts that are irrelevant to the project's static code analysis results.
-
Update PHP version in GitHub workflows to 8.3
Upgraded the PHP version from 8.1 to 8.3 in both static analysis and coding standards GitHub Action workflows. This ensures compatibility with the latest language features and improvements.
-
Suppress PHPStan warning on getInstance call
The @phpstan-ignore-line comment was added to suppress a specific PHPStan warning when calling getInstance in the LazyTo class. This ensures that static analysis does not flag this line while maintaining the intended functionality.
-
Add unit test for ProviderProvider
This commit introduces a new test case in `ProviderProviderTest.php` to verify the `ProviderProvider` functionality. It ensures that the `ProviderProvider` returns an instance of `FakeEngine` when invoked with the correct binding in the injector.
-
Change temp directory for container in VisitorTest
Updated the container instantiation in VisitorTest to use a temporary directory. This change improves test isolation by ensuring temporary files do not interfere with other tests or code.
-
Rename test method and add type hint to variable
Renamed the method `testInvoke` to `testGet` to better reflect its functionality. Added a type hint for the `$set` variable to indicate it contains objects, improving code clarity and type safety.
-
Refactor type annotations in ProviderProvider.
Updated the type annotations to use a generic template for better type safety and removed an unused comment in tests. This improves code readability and maintains consistency in type declarations.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.