-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding image_uri to docstring of runtime_env #48884
Changes from 8 commits
aca88e2
516fd0a
4ed7cc0
6208d5e
d110ea9
99d40c6
e80d4a7
dc49e47
b2a10d8
9cc21a0
c0f7f37
da77929
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -222,6 +222,10 @@ class MyClass: | |||||
pip={"packages":["tensorflow", "requests"], "pip_check": False, | ||||||
"pip_version": "==22.0.2;python_version=='3.8.11'"}) | ||||||
# Example for using image_uri | ||||||
RuntimeEnv( | ||||||
image_uri="rayproject/ray:2.39.0-py312-cu123") | ||||||
Args: | ||||||
py_modules: List of URIs (either in the GCS or external | ||||||
storage), each of which is a zip file that will be unpacked and | ||||||
|
@@ -266,6 +270,9 @@ class MyClass: | |||||
config: config for runtime environment. Either | ||||||
a dict or a RuntimeEnvConfig. Field: (1) setup_timeout_seconds, the | ||||||
timeout of runtime environment creation, timeout is in seconds. | ||||||
image_uri: URI to a container image. The Ray worker process runs | ||||||
in a container with this image. Does not work with runtime env | ||||||
fields that are not ``config`` and ``env_vars`` | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Just trying to avoid a double negative sentence. Please adjust accordingly. I'm not sure what the sentence is trying to say. To clarify, are you trying to say that this parameter can only be used with Also, can we capture these requirements in the signature? Otherwise the signature is misleading. |
||||||
""" | ||||||
|
||||||
known_fields: Set[str] = { | ||||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.