[core] Add invocation_stacktrace to Tasks and Actors. #48920
Conversation
Signed-off-by: Ruiyang Wang <[email protected]>
Signed-off-by: Ruiyang Wang <[email protected]>
Signed-off-by: Ruiyang Wang <[email protected]>
|
Hi @rynewang , it would be great to print out the parameters received by this ray task/actor! |
|
Q: do we want to default enable this feature? |
No. It will use more memory. |
May I know how much more memory will be consumed after turning on this feature? @jjyao |
| @@ -591,6 +594,9 @@ message TaskInfoEntry { | |||
| // If the task/actor is created within a placement group, | |||
| // this value is configured. | |||
| optional bytes placement_group_id = 26; | |||
| // Human readable stacktrace of the task invocation, or actor creation. The exact data | |||
| // format depends on the language. Only populated if the flag is enabled. | |||
| optional string invocation_stacktrace = 27; | |||
There was a problem hiding this comment.
Wondering would it be helpful also add the field to the TaskInfoEntry in export_task_event.proto and expose the field to the export API users? cc: @nikitavemuri
There was a problem hiding this comment.
yes but I am not familiar with that API. let's do this in another PR.
There was a problem hiding this comment.
Can we create an issue for that so that the item can be tracked?
We did not profile it, you can have a try after it's merged. Target end of this week. |
Signed-off-by: Ruiyang Wang <[email protected]>
Signed-off-by: Ruiyang Wang <[email protected]>
Signed-off-by: Ruiyang Wang <[email protected]>
Signed-off-by: Ruiyang Wang <[email protected]>
Signed-off-by: Ruiyang Wang <[email protected]>
Adds a new field
string invocation_stacktraceto TaskSpec. It's populated from language frontend (_raylet.pyx), ifRAY_enable_invocation_stacktraceis set totrue. The field is propagated toTaskEventandActorTableDataand through Dashboard APIs.Users can use
ray list task --detailas well as the Web UI. It works for Tasks, Actors (creation) and Actor Methods.The flag
RAY_enable_invocation_stacktraceis disabled by default, user can enable it if they want; so by default there should be no performance costs.Screenshots: