Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR fixes all invalid escape sequences, and enables the corresponding flake8 rule
W605
.This came up as part of #48921, leading to the wrong conclusion that the mypy hiccup is related to invalid escape sequences. Most likely it isn't (python/mypy#18215 (comment)), but it may still be a good idea to get rid of these to avoid unnecessary warnings and confusion.
I couldn't really figure out how flake8 is executed by the CI, because just running
flake8
on themaster
branch actually fails, and runningscripts/format.sh
doesn't seem to do anything (most likely because it only checks the diff, and isn't a full check). So I'm wondering if enabling theW605
check currently actually has much of an effect.Related issue number
Related to #48921
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.