Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support to clean worker table with maximum_gcs_dead_worker_cached_count #49030

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

zszheng
Copy link

@zszheng zszheng commented Dec 3, 2024

Why are these changes needed?

If there is no cleaning mechanism, the Worker table will continue to grow with each new Worker added to the cluster. Over time, this will lead to the issues mentioned by ISSUE(https://github.com/ray-project/ray/issues/49029), thereby affecting the stability and performance of the Ray cluster.

Related issue number

#49029

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@zszheng zszheng marked this pull request as ready for review December 3, 2024 10:00
@zszheng zszheng requested a review from a team as a code owner December 3, 2024 10:00
@jcotant1 jcotant1 added the core Issues that should be addressed in Ray Core label Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Issues that should be addressed in Ray Core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants