Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos #50979

Merged
merged 2 commits into from
Feb 28, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ package(
default_visibility = ["//visibility:public"],
)

# Hermetic python envionment, currently only used for CI infra and scripts.
# Hermetic python environment, currently only used for CI infra and scripts.

py_runtime(
name = "python3_runtime",
Expand Down
2 changes: 1 addition & 1 deletion ci/docker/ml.build.Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ set -euo pipefail
set -x

if [[ "${PYTHON-}" == "3.12" ]]; then
# hebo and doc test depdencies are not needed for 3.12 test jobs
# hebo and doc test dependencies are not needed for 3.12 test jobs
TRAIN_TESTING=1 TUNE_TESTING=1 DATA_PROCESSING_TESTING=1 \
INSTALL_HDFS=1 ./ci/env/install-dependencies.sh
else
Expand Down
4 changes: 2 additions & 2 deletions ci/env/install-core-prerelease-dependencies.sh
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
set -e

# install all unbounded dependencies in setup.py for ray core
# TOOD(scv119) reenable grpcio once https://github.com/grpc/grpc/issues/31885 is fixed.
# TOOD(scv119) reenable jsonschema once https://github.com/ray-project/ray/issues/33411 is fixed.
# TODO(scv119) reenable grpcio once https://github.com/grpc/grpc/issues/31885 is fixed.
# TODO(scv119) reenable jsonschema once https://github.com/ray-project/ray/issues/33411 is fixed.
DEPS=(aiosignal frozenlist requests protobuf)
python -m pip install -U --pre --upgrade-strategy=eager "${DEPS[@]}"
2 changes: 1 addition & 1 deletion ci/lint/check-banned-words.sh
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#!/usr/bin/env bash

# Checks Python and doc files for common mispellings.
# Checks Python and doc files for common misspellings.

BANNED_WORDS="RLLib Rllib Kuberay"

Expand Down
2 changes: 1 addition & 1 deletion ci/lint/check_import_order.py
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ def check_import(file):
parser.add_argument("path", help="File path to check. e.g. '.' or './src'")
# TODO(simon): For the future, consider adding a feature to explicitly
# white-list the path instead of skipping them.
parser.add_argument("-s", "--skip", action="append", help="Skip certian directory")
parser.add_argument("-s", "--skip", action="append", help="Skip certain directory")
args = parser.parse_args()

file_path = Path(args.path)
Expand Down
4 changes: 2 additions & 2 deletions cpp/include/ray/api.h
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ std::vector<std::shared_ptr<T>> Get(const std::vector<ray::ObjectRef<T>> &object
/// This method will be blocked until the object is ready.
///
/// \param[in] object The object reference which should be returned.
/// \param[in] timeout_ms The maximum amount of time in miliseconds to wait before
/// \param[in] timeout_ms The maximum amount of time in milliseconds to wait before
/// returning.
/// \return shared pointer of the result.
template <typename T>
Expand All @@ -89,7 +89,7 @@ std::shared_ptr<T> Get(const ray::ObjectRef<T> &object, const int &timeout_ms);
/// This method will be blocked until all the objects are ready.
///
/// \param[in] objects The object array which should be got.
/// \param[in] timeout_ms The maximum amount of time in miliseconds to wait before
/// \param[in] timeout_ms The maximum amount of time in milliseconds to wait before
/// returning.
/// \return shared pointer array of the result.
template <typename T>
Expand Down
4 changes: 2 additions & 2 deletions cpp/include/ray/api/object_ref.h
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ class ObjectRef {
/// Get the object from the object store.
/// This method will be blocked until the object is ready.
///
/// \param timeout_ms The maximum amount of time in miliseconds to wait before
/// \param timeout_ms The maximum amount of time in milliseconds to wait before
/// returning.
/// \return shared pointer of the result.
std::shared_ptr<T> Get(const int &timeout_ms) const;
Expand Down Expand Up @@ -207,7 +207,7 @@ class ObjectRef<void> {
/// Get the object from the object store.
/// This method will be blocked until the object is ready.
///
/// \param timeout_ms The maximum amount of time in miliseconds to wait before
/// \param timeout_ms The maximum amount of time in milliseconds to wait before
/// returning.
/// \return shared pointer of the result.
void Get(const int &timeout_ms) const {
Expand Down
2 changes: 1 addition & 1 deletion cpp/src/ray/runtime/task/local_mode_task_submitter.cc
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ ObjectID LocalModeTaskSubmitter::Submit(InvocationSpec &invocation,
const ActorCreationOptions &options) {
/// TODO(SongGuyang): Make the information of TaskSpecification more reasonable
/// We just reuse the TaskSpecification class and make the single process mode work.
/// Maybe some infomation of TaskSpecification are not reasonable or invalid.
/// Maybe some information of TaskSpecification are not reasonable or invalid.
/// We will enhance this after implement the cluster mode.
auto functionDescriptor = FunctionDescriptorBuilder::BuildCpp(
invocation.remote_function_holder.function_name);
Expand Down
2 changes: 1 addition & 1 deletion cpp/src/ray/test/examples/metric_example.cc
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ void test_metric(const std::string &exec_type, int total_time) {
ray::Gauge gauge("ray_test_gauge", "test gauge", "unit", {"tag1", "tag2"});
ray::Counter counter("ray_test_counter", "test counter", "unit", {"tag1", "tag2"});
ray::Histogram histogram(
"ray_test_histogram", "test hitogram", "unit", {1, 10}, {"tag1", "tag2"});
"ray_test_histogram", "test histogram", "unit", {1, 10}, {"tag1", "tag2"});
ray::Sum sum("ray_test_sum", "test sum", "unit", {"tag1", "tag2"});

std::unordered_map<std::string, std::string> tag_1 = {{"tag1", "increasing"},
Expand Down
2 changes: 1 addition & 1 deletion java/api/src/main/java/io/ray/api/ObjectRef.java
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ public interface ObjectRef<T> {
* Fetch the object from the object store, this method will block until the object is locally
* available.
*
* @param timeoutMs The maximum amount of time in miliseconds to wait before returning.
* @param timeoutMs The maximum amount of time in milliseconds to wait before returning.
* @throws RayTimeoutException If it's timeout to get the object.
*/
T get(long timeoutMs);
Expand Down
4 changes: 2 additions & 2 deletions java/api/src/main/java/io/ray/api/Ray.java
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ public static <T> ObjectRef<T> put(T obj, BaseActorHandle owner) {
* Get an object by `ObjectRef` from the object store.
*
* @param objectRef The reference of the object to get.
* @param timeoutMs The maximum amount of time in miliseconds to wait before returning.
* @param timeoutMs The maximum amount of time in milliseconds to wait before returning.
* @return The Java object.
* @throws RayTimeoutException If it's timeout to get the object.
*/
Expand All @@ -102,7 +102,7 @@ public static <T> T get(ObjectRef<T> objectRef) {
* Get a list of objects by `ObjectRef`s from the object store.
*
* @param objectList A list of object references.
* @param timeoutMs The maximum amount of time in miliseconds to wait before returning.
* @param timeoutMs The maximum amount of time in milliseconds to wait before returning.
* @return A list of Java objects.
* @throws RayTimeoutException If it's timeout to get the object.
*/
Expand Down