Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Browser Bookmarks] Support Prisma Access Browser #15473

Merged
merged 2 commits into from
Nov 22, 2024

Conversation

selfish
Copy link
Contributor

@selfish selfish commented Nov 21, 2024

Description

resolves #14821

Add Prisma-Access browser support for browser-bookmarks ext.
Fully working and tested on PAB. Also regression-tested on: Chrome, Firefox, Safari.

Implementation details:

Adding this required a tweak, as some "secure" derivative chrome browsers use a binary file instead of the text-based "Local State". I added a general fallback for such browsers which reinforces getChromiumProfiles. The only degraded functionality when fallback is triggered is that we can no longer know the default profile, so we have to assume unless "Default" exists.

Screencast

image

Checklist

@raycastbot raycastbot added extension fix / improvement Label for PRs with extension's fix improvements extension: browser-bookmarks Issues related to the browser-bookmarks extension labels Nov 21, 2024
@raycastbot
Copy link
Collaborator

raycastbot commented Nov 21, 2024

Thank you for your contribution! 🎉

🔔 @thomaslombart @sasivarnan @ahpatel @chupi33 @tleo19 @jum8ys you might want to have a look.

You can use this guide to learn how to check out the Pull Request locally in order to test it.

You can expect an initial review within five business days.

@selfish selfish changed the title Add browser-bookmarks support for prisma-access browser [Browser Bookmarks] Support Prisma Access Browser Nov 21, 2024
Copy link
Collaborator

@thomaslombart thomaslombart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, looks good to me! 🙌

@raycastbot raycastbot merged commit d9e9ad2 into raycast:main Nov 22, 2024
2 checks passed
Copy link
Contributor

Published to the Raycast Store:
https://raycast.com/raycast/browser-bookmarks

@raycastbot
Copy link
Collaborator

🎉 🎉 🎉

Such a great contribution deserves a reward, but unfortunately we couldn't find your Raycast account based on your GitHub username (@selfish).
Please link your GitHub account to your Raycast account to receive your credits and soon be able to exchange them for some swag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extension: browser-bookmarks Issues related to the browser-bookmarks extension extension fix / improvement Label for PRs with extension's fix improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Browser Bookmarks] Support Prisma Access Browser
3 participants