build.zig: Improve logic #4375
Merged
build.zig: Improve logic #4375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sagehane Thank you very much for the review! |
|
This breaks the build for me on Zig 0.13, because the path is no longer relative. Platform is macOS 14.6.1 |
|
Yes, I'll try. I'm sorry, seems this breaks for 0.12.0 too (which is the advertised supported version). There were other confusing aspects of the build system so I'll take a look. It looks like |
This was referenced Oct 13, 2024
psxdev
pushed a commit
to raylib4Consoles/raylib
that referenced
this pull request
Nov 18, 2024
* build.zig: Fix `@src` logic * build.zig: Clarify build error * build.zig: Add option for enabling `raygui` * build.zig: Expose `Options` type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the project was failing to build when trying
zig buildinside thesrc/dir instead of the root dir, due to hardcoding the path from the relative dir to"src", such that the compiler will try to look for$PROJECT_ROOT/src/src/<path>instead of$PROJECT_ROOT/src/<path>. I tried to fix all such instances of"src"with the parent directory of@src().file.Also, exposed the
Optionstype so people can do more things with it.