Feature/library card #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…w visible change in library
scroll by changhing overflow to auto
rayzhou-bit
approved these changes
Sep 14, 2023
scroll by changhing overflow to auto
…p into feature/libraryCard
|
Visit the preview URL for this PR (updated for commit f8d8be9): https://dmkit-e7e99--pr27-feature-librarycard-hob7ydcq.web.app (expires Mon, 09 Oct 2023 23:45:16 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 310a7f1d940a0f8f9346804f5fc60f8ba2a4f18d |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes changes to match new figma designs. Several color, size and other changes to the LibraryCard.
Roboto font has been added to the project. This adds ands imports Roboto-regular as "Roboto". The font is applied. Other weights of Roboto are also added but not imported as of yet.
Title from Card has been added to LibraryCard, replacing the older functionality. I added a dramatic Z-Index to the action dropdowns of Title which allows the popups dropdowns to be visible over the LibrarySearch component.
I've replaced the LibraryCard Border with an additional div wrapping the content within. This wrapper has a box-shadow that emulates the border. This shadow border has the ability to change thickness without altering the size of the entire element, stopping the forced shifting of content during the change. IT also solved the visible gap between rounded border and content corners.