added dispute #247
added dispute #247
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #247 +/- ##
==========================================
+ Coverage 96.83% 96.89% +0.06%
==========================================
Files 35 39 +4
Lines 631 773 +142
==========================================
+ Hits 611 749 +138
- Misses 20 24 +4 ☔ View full report in Codecov by Sentry. |
| ### Fetch All Disputes | ||
|
|
||
| ```rb | ||
| Razorpay::Dispute.all() |
There was a problem hiding this comment.
Do we allow any params for pagination ?
There was a problem hiding this comment.
No params according to this doc https://razorpay.com/docs/api/disputes/fetch-all
documents/dispute.md
Outdated
|
|
||
| **Parameters:** | ||
|
|
||
| | Name | Type | Description | |
documents/dispute.md
Outdated
| **Parameters:** | ||
|
|
||
| | Name | Type | Description | | ||
| |-------|-----------|--------------------------------------------------| |
documents/dispute.md
Outdated
| ``` | ||
| ------------------------------------------------------------------------------------------------------- | ||
|
|
||
| ### Fetch a Dispute |
There was a problem hiding this comment.
can you update the title for this section ?
There was a problem hiding this comment.
updated
razorpay-ruby/documents/dispute.md
Line 97 in e9c6f0c
documents/dispute.md
Outdated
|
|
||
| **Response:** | ||
| ```json | ||
| // Draft |
There was a problem hiding this comment.
Not clear on why this is added. Can you add more details if this is a specific case of response
There was a problem hiding this comment.
Separated both code snippets submit or draft
razorpay-ruby/documents/dispute.md
Line 144 in ec847c6
razorpay-ruby/documents/dispute.md
Line 227 in ec847c6
| refute_empty dispute.items, 'Dispute should be more than one' | ||
| end | ||
|
|
||
| def test_dispute_accept |
There was a problem hiding this comment.
please add test cases for failure cases of these APIs.
There was a problem hiding this comment.
Added failure test cases
documents/dispute.md
Outdated
| ```rb | ||
| # Use this API sample code for submit | ||
|
|
||
| Razorpay::Dispute.fetch(disputeId).contest({ |
There was a problem hiding this comment.
updated
razorpay-ruby/documents/dispute.md
Line 234 in 2e0b54f
Doc reference
Fetch All Disputes
Fetch a Dispute
Accept a Dispute
Contest a Dispute